[NTP]Unnecessary 'Restore default shortcut' option is enabled in 'Customize this page' menu list.
Reported by
dchau...@etouch.net,
Sep 6
|
||||
Issue descriptionChrome Version: 70.0.3538.9 (Official Build)Revision bbaf922671f0864634145724488000061f98a1a3-refs/branch-heads/3538@{#72} (32/64 bit). OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux(14.04 LTs) Pre-condition: Enable "Enable using the Google local NTP" and "New Tab Page Custom Links" flags from chrome://flags. What steps will reproduce the problem? 1. Launch Chrome, navigate to NTP and click on 'Add shortcut' icon. 2. Add the shortcut and click on 'Undo' button (Added shortcut will be deleted). 3. Now click on gear icon to open 'Customize this page' menu list and observe. Actual: Unnecessary 'Restore default shortcut' option is enabled even when shortcut is not added. Expected: 'Restore default shortcut' option should be disable when none of the Customize shortcut is added. This is a non-regression issue, seen from M-70 series, build #70.0.3510.0 NOTE: This issues is also reproducible on Dev #70.0.3534.4 and Canary #71.0.3544.0 Kindly review the attached screen-cast for reference. Thank you.
,
Sep 6
Kristi - looks like a bug. We shouldn't treat the shortcuts as custom unless the user actually completes an add, delete or edit.
,
Sep 6
This is behaving as expected. The add shortcut was completed and the other links were converted to custom links. The undo removes the new link, but the other links remain as custom links.
,
Sep 6
That seems off in spirit to me. Since in this case the user "changed their mind."
,
Sep 6
We can add another case for undoing the first change then
,
Sep 6
SGTM!
,
Sep 11
,
Oct 10
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1fc354749dc0f373181b5177e75c848cdbd493d commit c1fc354749dc0f373181b5177e75c848cdbd493d Author: Kristi Park <kristipark@chromium.org> Date: Fri Oct 12 22:57:04 2018 [NTP] Undoing the first custom link action will uninitialize custom links Undoing the first custom link action (i.e. the action that initializes custom links) will now uninitialize custom links. Screencast: https://screencast.googleplex.com/cast/NTM5NDQzOTE1MzM4NTQ3Mnw3MDNkZTY0Yy1hZQ Bug: 881256 Change-Id: I8d77fef71b581d5b6b81ce369d21afd8eb717c31 Reviewed-on: https://chromium-review.googlesource.com/c/1272137 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#599394} [modify] https://crrev.com/c1fc354749dc0f373181b5177e75c848cdbd493d/chrome/browser/search/instant_service.cc [modify] https://crrev.com/c1fc354749dc0f373181b5177e75c848cdbd493d/components/ntp_tiles/most_visited_sites.cc [modify] https://crrev.com/c1fc354749dc0f373181b5177e75c848cdbd493d/components/ntp_tiles/most_visited_sites.h [modify] https://crrev.com/c1fc354749dc0f373181b5177e75c848cdbd493d/components/ntp_tiles/most_visited_sites_unittest.cc
,
Oct 12
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yyushkina@chromium.org
, Sep 6Owner: kristip...@chromium.org