New issue
Advanced search Search tips

Issue 881224 link

Starred by 1 user
Status: Fixed
Owner:
maxmorin@chromium.org
Closed: Sep 6
Components:
EstimatedDays: ----
NextAction: 2018-09-07
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Spammy log from MediaStreamAudioProcessor.

Project Member Reported by maxmorin@chromium.org, Sep 6 
Sometimes, MediaStreamAudioProcessor cranks out logs like
"[1:4248:0901/235626.905498:WARNING:media_stream_audio_processor.cc(778)] Large audio delay, capture delay: 303ms; render delay: 0ms"
100 times a second. It would make sense to limit it to a just a few logs during its lifetime.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8618709051cb4993447fa5cedbc47c58bffcbeb7

commit 8618709051cb4993447fa5cedbc47c58bffcbeb7
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Sep 06 10:52:04 2018

Limit number of warnings for large audio delay.

Bug:  881224 
Change-Id: Ic6f18c1a7b5164175a70c9ebaade6722244b02fa
Reviewed-on: https://chromium-review.googlesource.com/1208271
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589133}
[modify] https://crrev.com/8618709051cb4993447fa5cedbc47c58bffcbeb7/content/renderer/media/stream/media_stream_audio_processor.cc
[modify] https://crrev.com/8618709051cb4993447fa5cedbc47c58bffcbeb7/content/renderer/media/stream/media_stream_audio_processor.h

Comment 2 by maxmorin@chromium.org, Sep 6

NextAction: 2018-09-07
Status: Fixed (was: Started)

Comment 3 by maxmorin@chromium.org, Sep 7

Labels: Merge-Request-70 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows

Comment 4 by monor...@bugs.chromium.org, Sep 7 

The NextAction date has arrived: 2018-09-07
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b63554d6c5b5da6882141b88253f03dfa8914427

commit b63554d6c5b5da6882141b88253f03dfa8914427
Author: Max Morin <maxmorin@chromium.org>
Date: Mon Sep 10 08:57:18 2018

[M70]Limit number of warnings for large audio delay.

Bug:  881224 
Change-Id: Ic6f18c1a7b5164175a70c9ebaade6722244b02fa
Reviewed-on: https://chromium-review.googlesource.com/1208271
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589133}(cherry picked from commit 8618709051cb4993447fa5cedbc47c58bffcbeb7)
Reviewed-on: https://chromium-review.googlesource.com/1215206
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#203}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b63554d6c5b5da6882141b88253f03dfa8914427/content/renderer/media/stream/media_stream_audio_processor.cc
[modify] https://crrev.com/b63554d6c5b5da6882141b88253f03dfa8914427/content/renderer/media/stream/media_stream_audio_processor.h
►

Sign in to add a comment