New issue
Advanced search Search tips

Issue 881214 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Accessibility icon is not visible properly in ubertray in OOBE Screen

Project Member Reported by kebalaji@chromium.org, Sep 6

Issue description

Chrome Version: 69.0.3497.82/10895.47.0 beta channel Kip,Daisy,Celes
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> In OOBE, enable any accessibility from ubertray and observe the accessibility icon is not visible properly in ubertray 

Actual: Accessibility icon is not visible properly in ubertray
Expected: Accessibility icon should be visible properly in ubertray

This is a Regression issue as same is working fine in 69.0.3497.35/10895.21.0 beta

NOTE: Issue is not seen on M70 as Accessibility icon is not shown in ubertray (   Issue 853690  )
      Issue is seen with Select-to-speak icon as well.

@jdufault: Please confirm the issue
 
ActualAccIcon.mp4
7.3 MB View Download
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2f06bf17702fb07972309b2cacce6970b8989bf

commit d2f06bf17702fb07972309b2cacce6970b8989bf
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Sep 11 17:46:44 2018

cros: Accessibility icon was invisible in shelf during OOBE

Bug:  881214 
Change-Id: I21675325deaf351bf2431935652c8bb2247bdb32
Reviewed-on: https://chromium-review.googlesource.com/1217352
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590381}
[modify] https://crrev.com/d2f06bf17702fb07972309b2cacce6970b8989bf/ash/system/tray_accessibility.cc
[modify] https://crrev.com/d2f06bf17702fb07972309b2cacce6970b8989bf/ash/system/tray_accessibility.h

Labels: Merge-Request-69 Merge-Request-70
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 11

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 11

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dc7d886aefb94a3df1b41b3dbbf8f9d1bf92e7c

commit 3dc7d886aefb94a3df1b41b3dbbf8f9d1bf92e7c
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Sep 11 20:08:35 2018

cros: Accessibility icon was invisible in shelf during OOBE

TBR=jdufault@google.com

(cherry picked from commit d2f06bf17702fb07972309b2cacce6970b8989bf)

Bug:  881214 
Change-Id: I21675325deaf351bf2431935652c8bb2247bdb32
Reviewed-on: https://chromium-review.googlesource.com/1217352
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590381}
Reviewed-on: https://chromium-review.googlesource.com/1220549
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#927}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/3dc7d886aefb94a3df1b41b3dbbf8f9d1bf92e7c/ash/system/tray_accessibility.cc
[modify] https://crrev.com/3dc7d886aefb94a3df1b41b3dbbf8f9d1bf92e7c/ash/system/tray_accessibility.h

Labels: M-70
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 12

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Marking fixed, merges to M69 and M70 are complete.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 13

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43d94b60c3845d9b8a57fbf43546d5c677a57879

commit 43d94b60c3845d9b8a57fbf43546d5c677a57879
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Sep 13 19:30:13 2018

cros: Accessibility icon was invisible in shelf during OOBE

TBR=jdufault@google.com

(cherry picked from commit d2f06bf17702fb07972309b2cacce6970b8989bf)

Bug:  881214 
Change-Id: I21675325deaf351bf2431935652c8bb2247bdb32
Reviewed-on: https://chromium-review.googlesource.com/1217352
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590381}
Reviewed-on: https://chromium-review.googlesource.com/1225299
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#382}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/43d94b60c3845d9b8a57fbf43546d5c677a57879/ash/system/tray_accessibility.cc
[modify] https://crrev.com/43d94b60c3845d9b8a57fbf43546d5c677a57879/ash/system/tray_accessibility.h

Sign in to add a comment