Findit has detected flake occurrences for the test HeadlessBrowserTest.CreateAndDoNotDestroyWebContents Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I5f27805aff16fe7db753c4700dbab5bf5ee0812d Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKQAWNocm9taXVtLm1lbW9yeS93aW4tYXNhbi8xMjgwL2hlYWRsZXNzX2Jyb3dzZXJ0ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1NHVmhaR3hsYzNOQ2NtOTNjMlZ5VkdWemRDNURjbVZoZEdWQmJtUkViMDV2ZEVSbGMzUnliM2xYWldKRGIyNTBaVzUwY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20HeadlessBrowserTest.CreateAndDoNotDestroyWebContents&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKQAWNocm9taXVtLm1lbW9yeS93aW4tYXNhbi8xMjgwL2hlYWRsZXNzX2Jyb3dzZXJ0ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1NHVmhaR3hsYzNOQ2NtOTNjMlZ5VkdWemRDNURjbVZoZEdWQmJtUkViMDV2ZEVSbGMzUnliM2xYWldKRGIyNTBaVzUwY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
Since findit blames https://chromium-review.googlesource.com/c/chromium/src/+/1180658 to have caused this I'm assigning the bug to mohsen@chromium.org
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7221e1a33a56ddaf67098a0065b961af3c567e00 commit 7221e1a33a56ddaf67098a0065b961af3c567e00 Author: Mohsen Izadi <mohsen@chromium.org> Date: Mon Oct 01 16:32:39 2018 Fix flakiness in HeadlessBrowserTest In HeadlessContentMainDelegate::RunProcess(), if the headless browser instance is destroyed before browser runner is shut down, GPU clients might end up accessing the destroyed object in the meantime. An example is when a client tries to establish a GPU channel ending up accessing destroyed HeadlessBrowserImpl::options in order to instantiate viz::GpuHostImpl. This CL changes the ordering to fix the race condition. BUG= 881211 TEST=headless_browsertests --gtest_filter=HeadlessBrowserTest.* Change-Id: I2518eeefcc1e446a59d680fa78eab88e26765404 Reviewed-on: https://chromium-review.googlesource.com/1251331 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595465} [modify] https://crrev.com/7221e1a33a56ddaf67098a0065b961af3c567e00/headless/lib/headless_content_main_delegate.cc
The flake has not happened since r595465 landed. Marking as fixed.
Comment 1 by markusheintz@chromium.org
, Sep 6Status: Assigned (was: Untriaged)