New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881208 link

Starred by 2 users
Status: Fixed
Owner:
█ harringtond@chromium.org
Last visit > 30 days ago
Closed: Oct 10
Cc:
█ sindhu.chelamcherla@chromium.org
jam@chromium.org
joelhockey@chromium.org
carlosk@chromium.org
█ harringtond@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Dcheck `committed_error_page_info_->auto_reload_triggered`

Reported by tsal...@gmail.com, Sep 6 
Steps to reproduce the problem:
1. Disable network
2. Open browser
3. Open vk.com (or any other site)
4. Open menu
5. Tap "refresh" and simultaneously hide browser tapping "home" button

What is the expected behavior?
Browser is hidden

What went wrong?
Dcheck fired

Crashed report ID: 

How much crashed? Just one tab

Is it a problem with a plugin? No 

Did this work before? No 

Chrome version: 70.0.3538.0  Channel: n/a
OS Version: 6
Flash Version: 

The problem is what `online` variable in code is hardcoded as `true`. 
It was fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/878327
But was reverted here: https://bugs.chromium.org/p/chromium/issues/detail?id=826062

Full stack:
09-28 23:18:41.388 30180-30195/org.chromium.chrome:sandboxed_process10 A/chromium: [FATAL:net_error_helper_core.cc(960)] Check failed: committed_error_page_info_->auto_reload_triggered. 
                                                                                   #00 0xa31bac0f /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000dbc0f
                                                                                   #01 0x85cf5711 /data/app/org.chromium.chrome-2/lib/arm/libchrome.cr.so+0x013dd711
                                                                                   #02 0x87b44623 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00f36623
                                                                                   #03 0x87b551fd /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00f471fd
                                                                                   #04 0x876b7f7b /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00aa9f7b
                                                                                   #05 0x87b5515b /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00f4715b
                                                                                   #06 0x87b53105 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00f45105
                                                                                   #07 0x87b52001 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00f44001
                                                                                   #08 0x874657e5 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x008577e5
                                                                                   #09 0xa2dfff29 /data/app/org.chromium.chrome-2/lib/arm/libipc.cr.so+0x00019f29
                                                                                   #10 0xa31abdbb /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000ccdbb
                                                                                   #11 0xa31b1e9b /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000d2e9b
                                                                                   #12 0xa31f0595 /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x00111595
                                                                                   #13 0xa31abdbb /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000ccdbb
                                                                                   #14 0xa31b1e9b /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000d2e9b
                                                                                   #15 0xa31c6709 /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000e7709
                                                                                   #16 0xa31c68e1 /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000e78e1
                                                                                   #17 0xa31c69cb /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000e79cb
                                                                                   #18 0xa31c7f13 /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000e8f13
                                                                                   #19 0xa31c650d /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000e750d
                                                                                   #20 0xa31d9e27 /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000fae27
                                                                                   #21 0x87b5b9c9 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00f4d9c9
                                                                                   #22 0x87be00fb /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00fd20fb
                                                                                   #23 0x8ce25a41 /data/app/org.chromium.chrome-2/lib/arm/libembedder.cr.so+0x0000fa41
                                                                                   #24 0x87bdf8c7 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00fd18c7
09-28 23:18:41.388 30180-30195/org.chromium.chrome:sandboxed_process10 A/libc: Fatal signal 6 (SIGABRT), code -6 in tid 30195 (CrRendererMain)

                                                                               [ 09-28 23:18:41.389   256:  256 W/         ]
                                                                               debuggerd: handling request: pid=30180 uid=99664 gid=99664 tid=30195
09-28 23:18:41.485 30256-30256/? A/DEBUG: pid: 30180, tid: 30195, name: CrRendererMain  >>> org.chromium.chrome:sandboxed_process10 <<<
09-28 23:18:41.487 30256-30256/? A/DEBUG: Abort message: '[FATAL:net_error_helper_core.cc(960)] Check failed: committed_error_page_info_->auto_reload_triggered. 
                                          #00 0xa31bac0f /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000dbc0f
                                          #01 0x85cf5711 /data/app/org.chromium.chrome-2/lib/arm/libchrome.cr.so+0x013dd711
                                          #02 0x87b44623 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00f36623
                                          #03 0x87b551fd /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00f471fd
                                          #04 0x876b7f7b /data/app/org.chromium.chrome-2/lib/arm/libconte
09-28 23:18:41.513 30256-30256/? A/DEBUG:     #05 pc 0013e5d1  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base5debug13BreakDebuggerEv+20)
09-28 23:18:41.513 30256-30256/? A/DEBUG:     #06 pc 000dbe1f  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN7logging10LogMessageD2Ev+642)
09-28 23:18:41.513 30256-30256/? A/DEBUG:     #07 pc 013dd70f  /data/app/org.chromium.chrome-2/lib/arm/libchrome.cr.so (offset 0x624000)
09-28 23:18:41.513 30256-30256/? A/DEBUG:     #08 pc 00f36623  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000) (_ZN7content15RenderFrameImpl9WasHiddenEv+38)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #09 pc 00f471fb  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000) (_ZN7content12RenderWidget11OnWasHiddenEv+62)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #10 pc 00aa9f79  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #11 pc 00f47159  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #12 pc 00f45103  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000) (_ZN7content12RenderWidget17OnMessageReceivedERKN3IPC7MessageE+338)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #13 pc 00f43fff  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000) (_ZN7content14RenderViewImpl17OnMessageReceivedERKN3IPC7MessageE+982)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #14 pc 008577e5  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000) (_ZN7content15ChildThreadImpl24ChildThreadMessageRouter12RouteMessageERKN3IPC7MessageE+8)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #15 pc 00019f29  /data/app/org.chromium.chrome-2/lib/arm/libipc.cr.so (offset 0x16000) (_ZN3IPC12ChannelProxy7Context17OnDispatchMessageERKNS_7MessageE+64)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #16 pc 000ccdbb  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #17 pc 000d2e99  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base5debug13TaskAnnotator7RunTaskEPKcPNS_11PendingTaskE+124)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #18 pc 00111593  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base16sequence_manager8internal20ThreadControllerImpl6DoWorkENS2_8WorkTypeE+330)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #19 pc 000ccdbb  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #20 pc 000d2e99  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base5debug13TaskAnnotator7RunTaskEPKcPNS_11PendingTaskE+124)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #21 pc 000e7707  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base11MessageLoop7RunTaskEPNS_11PendingTaskE+130)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #22 pc 000e78df  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE+66)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #23 pc 000e79c9  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base11MessageLoop6DoWorkEv+148)
09-28 23:18:41.514 30256-30256/? A/DEBUG:     #24 pc 000e8f13  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE+104)
09-28 23:18:41.515 30256-30256/? A/DEBUG:     #25 pc 000e750d  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base11MessageLoop3RunEb+68)
09-28 23:18:41.515 30256-30256/? A/DEBUG:     #26 pc 000fae27  /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so (offset 0xc1000) (_ZN4base7RunLoop3RunEv+138)
09-28 23:18:41.515 30256-30256/? A/DEBUG:     #27 pc 00f4d9c7  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000)
09-28 23:18:41.515 30256-30256/? A/DEBUG:     #28 pc 00fd20f9  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000)
09-28 23:18:41.515 30256-30256/? A/DEBUG:     #29 pc 0000fa41  /data/app/org.chromium.chrome-2/lib/arm/libembedder.cr.so (offset 0xd000) (_ZN15service_manager4MainERKNS_10MainParamsE+1072)
09-28 23:18:41.515 30256-30256/? A/DEBUG:     #30 pc 00fd18c5  /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so (offset 0x840000) (Java_org_chromium_content_app_ContentMain_nativeStart+184)
09-28 23:18:41.515 30256-30256/? A/DEBUG:     #31 pc 0126d015  /data/app/org.chromium.chrome-2/oat/arm/base.odex (offset 0x125c000)

Comment 1 by tsal...@gmail.com, Sep 6 

Tested on commit:

commit b2d233c40cf68e6d66ed9788d211a63086711be6 (HEAD -> master, origin/master, origin/HEAD)
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date:   Thu Aug 30 16:18:40 2018 +0000

    AbortError: Another PaymentRequest UI is already showing

Comment 2 by chelamcherla@chromium.org, Sep 7

Labels: Needs-triage-Mobile

Comment 3 by chelamcherla@chromium.org, Sep 7

Cc: joelhockey@chromium.org jam@chromium.org chelamcherla@chromium.org
Labels: Needs-Feedback
As per revert CL in comment#0 cc'ing joelhockey@ and jam@ from fixed cl for further inputs on this issue.

@ tsalexn: Could you please provide 16 digit crash id from chrome://crashes if you see any. This would help in further triaging of the issue.

Thanks!

Comment 4 by joelhockey@chromium.org, Sep 7 

I don't have any particular knowledge of this code.  I reverted a CL which had caused a bug in ChromeOS Files app.  It looks like the challenge is to figure out which parts of that CL are needed and what else needs to change to not break other things.

Comment 5 Deleted

Comment 6 by tsal...@gmail.com, Sep 10 

Sorry, no crash-id, it was disabled on build I tested.

I rechecked the issue. The problem with network is a side-problem, because there is another case:
1. Open browser
2. Open http://absdadeawkdokawod.net (".net" is important, and the site must be unresolved so that autoreload would be triggered)
3. Open menu
4. Tap "refresh" and simultaneously hide browser tapping "home" or "app switch" button to hide chrome

It seems the problem is in `OnCommitLoad` function which makes `committed_error_page_info_ = std::move(pending_error_page_info_);`, but doesn't take into account that `committed_error_page_info_->auto_reload_triggered` was `true` before and autoreload timer still ticking after `move()`.
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 10

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by dtapu...@chromium.org, Sep 11

Components: Internals>Network

Comment 9 by eroman@chromium.org, Sep 14

Components: -Internals>Network UI>Browser>Offline

Comment 10 by dim...@chromium.org, Sep 24

Cc: -chelamcherla@chromium.org sindhu.chelamcherla@chromium.org carlosk@chromium.org harringtond@chromium.org
Owner: jianli@chromium.org
Status: Assigned (was: Unconfirmed)
+some offline folks to take a look, familiarity with this might be a part of the future auto-load impl...

Comment 11 by carl...@google.com, Sep 24 

jianli@: please CC harringtond@ and myself in the CLs for this fix. Thanks.

Comment 12 by harringtond@chromium.org, Sep 24 

At the DCHECK, auto_reload_paused_=true, while auto_reload_timer_->IsRunning()=true .

The only place where auto_reload_timer_ is set to true without also pausing the timer is here:
https://cs.chromium.org/chromium/src/chrome/renderer/net/net_error_helper_core.cc?targetos=chromium-android&g=0&l=929

So I think the timer should be stopped there too.

Comment 13 by harringtond@chromium.org, Sep 24

Owner: harringtond@chromium.org
I'll send a CL

Comment 14 by tsal...@gmail.com, Sep 24 

harringtond@ the problem actually about DCHECK below: DCHECK(committed_error_page_info_->auto_reload_triggered);
But still interesting observation

Comment 15 by harringtond@chromium.org, Sep 24 

Thanks, sending another CL soon.
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f2d67efff0ea5f5eaf916f4c302996ee68a1af

commit d9f2d67efff0ea5f5eaf916f4c302996ee68a1af
Author: Dan Harrington <harringtond@chromium.org>
Date: Fri Oct 05 17:33:21 2018

Fix DCHECK on net error page

DCHECK(committed_error_page_info_->auto_reload_triggered) was failing.
This is possible because when assigning a new value to
committed_error_page_info_, the auto load timer can still be active.

R=jianli

Bug:  881208 
Change-Id: I361df3e17bef122f143331107a76d04487b32fea
Reviewed-on: https://chromium-review.googlesource.com/c/1240872
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#597183}
[modify] https://crrev.com/d9f2d67efff0ea5f5eaf916f4c302996ee68a1af/chrome/renderer/net/net_error_helper_core.cc
[modify] https://crrev.com/d9f2d67efff0ea5f5eaf916f4c302996ee68a1af/chrome/renderer/net/net_error_helper_core_unittest.cc

Comment 17 by harringtond@chromium.org, Oct 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment