"fast/js/regress/splice-to-remove.html" is flaky |
||||||
Issue description"fast/js/regress/splice-to-remove.html" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMAsSBUZsYWtlIiVmYXN0L2pzL3JlZ3Jlc3Mvc3BsaWNlLXRvLXJlbW92ZS5odG1sDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 10
The test times out on linux, mac and windows. Toon, could you please route this to check whether this is a perf regression? I'll disable the test.
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70908f40261c98b5d0453584dde49ef843edfb3c commit 70908f40261c98b5d0453584dde49ef843edfb3c Author: Dominic Battre <battre@chromium.org> Date: Mon Sep 10 10:02:28 2018 Label fast/js/regress/splice-to-remove.html as timing out TBR=verwaest@chromium.org NOTRY=true Bug: 881207 Change-Id: I94bf1aba386877948036d28cefe08629a817531c Reviewed-on: https://chromium-review.googlesource.com/1215287 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#589871} [modify] https://crrev.com/70908f40261c98b5d0453584dde49ef843edfb3c/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 1
,
Oct 22
Hi, this should be fixed. I briefly ran the test and it takes ~57 milliseconds on linux, whereas, before my fix it took 2 seconds (!). Here is the repairing CL, in the tree for about a week now: commit 696b2ceddd38afbff8776895cf9aadeea960d84f Author: Mike Stanton <mvstanton@chromium.org> Date: Wed Oct 10 16:39:19 2018 +0200 [Builtins] Array.prototype.splice performance improvements a) The current size of the backing store for the array under splice wasn't considered. Additionally, allocate the array with the normal growing strategy. b) Use primitives memcpy and memmove when appropriate. These calls are wrapped in new CSA functions MoveElements and CopyElements, which use the C functions when a write barrier isn't needed (otherwise they just copy elements in a loop). Bug: chromium:880780 Change-Id: I39a917c71036f52250c68f2cced77a1c24f97b67 Reviewed-on: https://chromium-review.googlesource.com/c/1243104 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56534}
,
Oct 22
Dominic, would you like to re-enable the test or should I?
,
Oct 22
Please re-enable the test. I was just sheriffing. Thank you. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by markusheintz@chromium.org
, Sep 6