New issue
Advanced search Search tips

Issue 881192 link

Starred by 0 users
Status: Fixed
Owner:
khushals...@chromium.org
Closed: Oct 12
Cc:
cblume@chromium.org
khushals...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

100% improvement in blink_perf.image_decoder at 585673:585770

Project Member Reported by khushals...@chromium.org, Sep 6 
The benchmark is not working anymore, and I think its this patch: https://chromium-review.googlesource.com/c/chromium/src/+/1185793. For some reason, after this patch "ImageFrameGenerator::Decode" time has dropped to 0. I suspected maybe its a change in the name of a trace event, but doesn't look like the patch did that. We should investigate what it is and fix the benchmark.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 6 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=881192

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9bfdd9632a22522b3c0e812da7b8f7bf4b235bf0a2d654d7c696375d0edeb59c


Bot(s) for this bug's original alert(s):

Win 7 Perf

blink_perf.image_decoder - Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 6

Cc: khushals...@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/113f3943640000

blink: Refactor ImageFrameGenerator to support multi-thread use. by khushalsagar@chromium.org
https://chromium.googlesource.com/chromium/src/+/98afd4cc3f640881b0d20aeaa89ecaa50e164b4f
8250 → 0 (-8250)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e7d59581eb6cfa55c95a8d976f155d11ac1e537

commit 4e7d59581eb6cfa55c95a8d976f155d11ac1e537
Author: Khushal <khushalsagar@google.com>
Date: Wed Sep 26 22:07:24 2018

blink/images: Restore trace event for image decodes.

This trace event was removed in [1] but is needed by telemetry scripts
to measure the decode time for images in perf tests.

NOTE TO PERF SHERRIFS
A regression in blink_perf.image_decoder benchmark is expected from this
change since it restores this benchmark.

R=chrishtr@chromium.org

Bug:  881192 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I100082d30f2ebed4c8d7efa91a22c4670d4c2492
Reviewed-on: https://chromium-review.googlesource.com/1246272
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594492}
[modify] https://crrev.com/4e7d59581eb6cfa55c95a8d976f155d11ac1e537/third_party/blink/renderer/platform/graphics/image_decoder_wrapper.cc

Comment 6 by khushals...@chromium.org, Oct 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment