New issue
Advanced search Search tips

Issue 881188 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in blink::SVGInlineTextBox::SelectionRectForTextFragment

Project Member Reported by ClusterFuzz, Sep 6

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4759976556625920

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::SVGInlineTextBox::SelectionRectForTextFragment
  blink::SVGInlineTextBox::LocalSelectionRect
  blink::LayoutSVGInlineText::LocalCaretRect
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4759976556625920

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 6

Components: Blink>SVG
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 6

Cc: yosin@chromium.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Introduce TextSegments class with Finder interface by yosin@chromium.org - https://chromium.googlesource.com/chromium/src/+/6ea45774b43642488abee6688f0ac328903c2400

Make EndOfSentence() to utilize TextOffsetMapping by yosin@chromium.org - https://chromium.googlesource.com/chromium/src/+/6535528f00c742b6cb9dcce8e46567048ac0dadc

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Status: Available (was: Untriaged)
Regression range is useless.

This one is non-obvious, because I can see nothing in the test case that would get us a text height after zoom of 10e18. Might be a real bug.
Owner: f...@opera.com
Status: Assigned (was: Available)
Taking a look.
I guess this could be be the skewY(90) (after some rounding et.c) yielding a value like that.
Indeed, I should have noticed the skew. Seems like we should push skews of 90 away from 90.
I think we are in actuality already (due to precision issues.) I'm making a simpler fix for this though (https://chromium-review.googlesource.com/c/chromium/src/+/1209923)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 7

Project Member

Comment 9 by ClusterFuzz, Sep 8

ClusterFuzz has detected this issue as fixed in range 589470:589471.

Detailed report: https://clusterfuzz.com/testcase?key=4759976556625920

Fuzzer: miaubiz_svg_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::SVGInlineTextBox::SelectionRectForTextFragment
  blink::SVGInlineTextBox::LocalSelectionRect
  blink::LayoutSVGInlineText::LocalCaretRect
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=589470:589471

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4759976556625920

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Sep 8

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4759976556625920 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment