New issue
Advanced search Search tips

Issue 881180 link

Starred by 1 user

Issue metadata

Status: ExternalDependency
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Maybe fire events on XHR even after its frame is gone?

Project Member Reported by timothygu@chromium.org, Sep 6

Issue description

This is depends on the resolution from https://github.com/whatwg/html/issues/4007, and is filed here in order to be a reference for a currently failing test in TestExpectations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/177405e7c668ac98062daf7d48361b38ec0db283

commit 177405e7c668ac98062daf7d48361b38ec0db283
Author: Timothy Gu <timothygu@chromium.org>
Date: Fri Sep 07 21:03:21 2018

Fire XHR abort event from a task

A test for this new behavior is included as
external/wpt/xhr/abort-after-stop.htm.

This also means that XHR abort and readystatechange events from
navigation is no longer fired. Because of that,
external/wpt/xhr/open-url-multi-window-4.htm now times out rather than
fails on an assertion, aligning with Firefox. A TestExpectations entry
has been added with a bug that tracks fixing this test in spec or
upstream in WPT. A few other test expectations were updated as well to
account for this.

http/tests/navigation/reentrant-xhr-onabort-crash-during-commit.html no
longer works as intended, as abort event is no longer fired
synchronously (and thus does not expose the same crash surface). It is
replaced with an EventSource-based test that functions the same way as
XHR before this CL. Note, currently EventSource's error event suffers
from the same problem as XHR's abort event, and the class might undergo
the same change as this in the future. We will look into an alternative
for this test when that change is done.

Bug:  879620 , 881180
Change-Id: I5a91047086d06347794656f92511a53c22401b5e
Reviewed-on: https://chromium-review.googlesource.com/1208672
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589634}
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/external/wpt/xhr/abort-after-stop.htm
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/external/wpt/xhr/open-after-abort.htm
[add] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/external/wpt/xhr/open-after-stop.window.js
[delete] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/third_party/WebKit/LayoutTests/external/wpt/xhr/open-url-multi-window-4-expected.txt
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/fast/dom/Document/open-with-pending-load2-expected.txt
[add] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/http/tests/navigation/reentrant-eventsource-onerror-crash-during-commit-expected.txt
[add] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/http/tests/navigation/reentrant-eventsource-onerror-crash-during-commit.html
[delete] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/third_party/WebKit/LayoutTests/http/tests/navigation/reentrant-xhr-onabort-crash-during-commit-expected.txt
[delete] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/third_party/WebKit/LayoutTests/http/tests/navigation/reentrant-xhr-onabort-crash-during-commit.html
[add] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/http/tests/navigation/resources/event-stream-with-delay.php
[add] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/http/tests/navigation/resources/reentrant-eventsource-onerror-crash-during-commit-iframe.html
[delete] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/third_party/WebKit/LayoutTests/http/tests/navigation/resources/reentrant-xhr-onabort-crash-during-commit-iframe.html
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/navigation-should-abort-expected.txt
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
[modify] https://crrev.com/177405e7c668ac98062daf7d48361b38ec0db283/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h

Components: Blink>Network>XHR

Sign in to add a comment