New issue
Advanced search Search tips

Issue 881168 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Sep 14
Cc:
asanka@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add browser tests for DNS and auth configuration of NetworkService.

Project Member Reported by mmenke@chromium.org, Sep 6 
While testing actual DNS behavior and NTLM/Negotiate authentication in browser tests may be prohibitively difficult (We *could* actually implement a mock local DNS server), we can at least grab the settings the SystemNetworkContextManager sends to the NetworkService, and make sure they are correct.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1439246c5610b14a87e00e928e73c3b52bf35db9

commit 1439246c5610b14a87e00e928e73c3b52bf35db9
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Sep 11 21:44:40 2018

Add browser tests for HTTP auth and DNS stub resolver configuration.

These aren't full integration tests - they don't make sure that the
correct configuration is sent to the network service on start, or that
the configuration is updated as the prefs change. Instead, they just
check the code that maps prefs to NetworkService configuration structs.

Bug:  881168 
Change-Id: I923d8536686ca3a10083c1b8ba0b76c5703e1f9d
Reviewed-on: https://chromium-review.googlesource.com/1210365
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590481}
[modify] https://crrev.com/1439246c5610b14a87e00e928e73c3b52bf35db9/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/1439246c5610b14a87e00e928e73c3b52bf35db9/chrome/browser/net/system_network_context_manager.h
[add] https://crrev.com/1439246c5610b14a87e00e928e73c3b52bf35db9/chrome/browser/net/system_network_context_manager_browsertest.cc
[modify] https://crrev.com/1439246c5610b14a87e00e928e73c3b52bf35db9/chrome/test/BUILD.gn

Comment 2 by mmenke@chromium.org, Sep 14

Status: Fixed (was: Assigned)

Comment 3 by asanka@chromium.org, Sep 16

Labels: Postmortem-Followup
►

Sign in to add a comment