New issue
Advanced search Search tips

Issue 881157 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"Always show shelf" should be in sentence case

Project Member Reported by kejiashao@chromium.org, Sep 6

Issue description

Right now it's in title case: Always Show Shelf
It should be in sentence case: Always show shelf


 
Labels: -Pri-3 Pri-1
This is string change, aren't we way past the string freeze? I suggest moving this to M71
Status: Started (was: Untriaged)
Labels: -M-70 M-71
Sounds good! I wasn't sure if we were able to fix past string freeze like last year.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5487b30ef81762d4b5581f9f03da73837aaaa377

commit 5487b30ef81762d4b5581f9f03da73837aaaa377
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Thu Sep 06 19:54:54 2018

Change "Always Show Shelf" string to sentence case.

Bug:  881157 
Test: manual
Change-Id: I809b94d822a40432e108519d07c27787a71f86be
Reviewed-on: https://chromium-review.googlesource.com/1211111
Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589253}
[modify] https://crrev.com/5487b30ef81762d4b5581f9f03da73837aaaa377/ash/ash_strings.grd

Status: Fixed (was: Started)

Sign in to add a comment