Quick note, in overview the shelf should be displayed like it should be in peeking, fullscreen and homecher, refering to bug 881166

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8677e6fb413520b5f36118092bff009095c9d829

commit 8677e6fb413520b5f36118092bff009095c9d829
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Sep 07 03:20:51 2018

shelf: Show shelf in overview even when auto hide is on.

Test: ash_unittests ShelfLayoutManagerTest.VisibleInOverview
Bug:  881153 
Change-Id: I2b5b8122831b5c71bc4ee4fcf4360d7626e11f0b
Reviewed-on: https://chromium-review.googlesource.com/1211741
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589422}
[modify] https://crrev.com/8677e6fb413520b5f36118092bff009095c9d829/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/8677e6fb413520b5f36118092bff009095c9d829/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/8677e6fb413520b5f36118092bff009095c9d829/ash/shelf/shelf_layout_manager_unittest.cc

Thanks Sammie. Add Merge-Request-70 for auto-hide change.

Thanks Min.

I added it to https://docs.google.com/spreadsheets/d/1eRRLWsBcv5CwHGp_P05KCcYh0HSj12Mewjm-4u7Ff-8/edit#gid=0.

The launcher and shelf guys want to handle the merges.

Min, I tested and it does not seem like this patch fixed the split view shelf issue you were showing yesterday.

Thanks Sammie. The crash that we talked about yesterday is here, https://bugs.chromium.org/p/chromium/issues/detail?id=882553

I did some investigation and feel it might related to some change of the home launcher.

Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

re#9: Sorry I think I didn't get the repro steps correctly when I tried it, but it does seem to fix the split view issue. I'll post more detail on the other bug.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Issue 882653 has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/177e9acadc7399b0f7c5c95baa919c2f7e180fad

commit 177e9acadc7399b0f7c5c95baa919c2f7e180fad
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Sep 17 22:09:05 2018

shelf: Show shelf in overview even when auto hide is on.

Test: ash_unittests ShelfLayoutManagerTest.VisibleInOverview
Bug:  881153 
Change-Id: I2b5b8122831b5c71bc4ee4fcf4360d7626e11f0b
Reviewed-on: https://chromium-review.googlesource.com/1211741
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589422}(cherry picked from commit 8677e6fb413520b5f36118092bff009095c9d829)
Reviewed-on: https://chromium-review.googlesource.com/1229174
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#461}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/177e9acadc7399b0f7c5c95baa919c2f7e180fad/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/177e9acadc7399b0f7c5c95baa919c2f7e180fad/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/177e9acadc7399b0f7c5c95baa919c2f7e180fad/ash/shelf/shelf_layout_manager_unittest.cc