New issue
Advanced search Search tips

Issue 881134 link

Starred by 4 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Launcher-Polish


Sign in to add a comment

Shelf blur appears suddenly after shelf reveals.

Project Member Reported by flackr@chromium.org, Sep 6

Issue description

Chrome Version: 70.0.3538.7 (Official Build) dev (64-bit)
OS: ChromeOS

What steps will reproduce the problem?
(1) Set the shelf to auto-hide or enter immersive mode.
(2) Move mouse to the bottom of the screen to reveal the shelf.

What is the expected result?
Expect the shelf to slide up with no sudden visual disruptions.

What happens instead?
Instead, the shelf slides up with no blur, and then when it reaches the fully revealed state suddenly switches to blurring the contents behind it. Depending on the content it can create a noticeable flash between the unblurred and blurred content.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Cc: omrilio@chromium.org sgabr...@chromium.org
Labels: -Pri-3 M-70 Pri-1
Owner: manucornet@chromium.org
Status: Assigned (was: Untriaged)
+omrilio who also reported this issue to me.
Nice catch, thank you!

Is there a way to repro this in the Ozone/sandbox thing? Shelf auto-hiding doesn't seen to do anything there. Are there flags I'm missing?
Cc: minch@chromium.org newcomer@chromium.org
I believe you have to open a window to make the shelf actually hide. This should work in the emulator but I haven't tried. Maybe minch@ knows!
Cc: wutao@chromium.org
re #3, yes, we need to have a visible window to make shelf actually hide. I can repro this in the emulator. It will be more obviously if add --ui-slow-animations in your build.
Sorry I don't have too much thought about the blur part, seems that there is no animation for the blur of the shelf. I guess wutao@ might have more knowledge for blur.
When blur is applied, it will appear in the next frame.
Unless you set blur radius progressively when the Shelf becomes visible.

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5990315053b5d925c5ce4bcb4332df9cc9e95e2

commit c5990315053b5d925c5ce4bcb4332df9cc9e95e2
Author: Manu Cornet <manucornet@chromium.org>
Date: Tue Sep 11 08:06:03 2018

CrOS Shelf: enable bg blur only when app list blue is on

Enable shelf background blur only when the launcher's background
blur is enabled.

This allows for a more consistent user experience, and may also
help with performance on some devices.

Bug: 879962,881134
Change-Id: I40015199f3312b62ef7b175167b65d5a9a6e352a
Reviewed-on: https://chromium-review.googlesource.com/1217584
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590230}
[modify] https://crrev.com/c5990315053b5d925c5ce4bcb4332df9cc9e95e2/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/c5990315053b5d925c5ce4bcb4332df9cc9e95e2/ash/shelf/shelf_widget.cc

Summary: Shelf blur / rounded corners appears suddenly after shelf reveals. (was: Shelf blur appears suddenly after shelf reveals.)
Updating description to also mention corner glitch, which I think come from the same issue.
Cc: abodenha@chromium.org ddavenp...@chromium.org manucornet@chromium.org
 Issue 882150  has been merged into this issue.
Ok, after a lot of trial and error to try to figure this out, it seems like this is a problem coming from the interaction between blur and opacity.

The shelf's opacity increases from 0 to 1 as it animates from being hidden to being shown. Apparently the blur doesn't want to take effect on a partially transparent layer.
So even if I update the blur radius during the animation, no blur actually happens until the animation is over and the shelf is opaque.
Cc: osh...@chomium.org
Adding Mitsuru who will probably have a lot of insights on this. :-)
Cc: -osh...@chomium.org osh...@chromium.org
Summary: Shelf blur appears suddenly after shelf reveals. (was: Shelf blur / rounded corners appears suddenly after shelf reveals.)
 Issue 882029  has been merged into this issue.
Labels: -M-70 M-71
This is a little bit of a hairy problem with animation, layers and masks that I haven't quite figured out yet. It will likely take some more time, and I may want to change the current model of shelf auto-hide animation (animate position instead of height). I think it's safer to punt this to M-71.
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15020b8f5d62bd73aa871b2fa50f1ccee4c37125

commit 15020b8f5d62bd73aa871b2fa50f1ccee4c37125
Author: Manu Cornet <manucornet@chromium.org>
Date: Wed Sep 19 15:22:33 2018

CrOS Shelf: Set background blur only once

This does not fix any known issues (and in fact doesn't change any
behavior), but it seems wasteful to set the background blur to the
exact same value multiple times.

Bug: 881134
Change-Id: I3762c486385d9136f1aea3e50d1e304d69aef141
Reviewed-on: https://chromium-review.googlesource.com/1233122
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592408}
[modify] https://crrev.com/15020b8f5d62bd73aa871b2fa50f1ccee4c37125/ash/shelf/shelf_widget.cc

Labels: Merge-Request-70 M-70
Project Member

Comment 18 by sheriffbot@chromium.org, Sep 20

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 22

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b23fbb63c5179016e33cafc87edaeb5c81a0cfe6

commit b23fbb63c5179016e33cafc87edaeb5c81a0cfe6
Author: Manu Cornet <manucornet@chromium.org>
Date: Sat Sep 22 02:39:16 2018

CrOS Shelf: enable bg blur only when app list blue is on

Enable shelf background blur only when the launcher's background
blur is enabled.

This allows for a more consistent user experience, and may also
help with performance on some devices.

Bug: 879962,881134
Change-Id: I40015199f3312b62ef7b175167b65d5a9a6e352a
Reviewed-on: https://chromium-review.googlesource.com/1217584
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590230}(cherry picked from commit c5990315053b5d925c5ce4bcb4332df9cc9e95e2)
Reviewed-on: https://chromium-review.googlesource.com/1239295
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#581}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b23fbb63c5179016e33cafc87edaeb5c81a0cfe6/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/b23fbb63c5179016e33cafc87edaeb5c81a0cfe6/ash/shelf/shelf_widget.cc

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 24

Labels: -merge-approved-70
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/429731975a4d5b6dea20eaf9eab9296195f5418a

commit 429731975a4d5b6dea20eaf9eab9296195f5418a
Author: Manu Cornet <manucornet@chromium.org>
Date: Mon Sep 24 21:18:48 2018

CrOS Shelf: Set background blur only once

This does not fix any known issues (and in fact doesn't change any
behavior), but it seems wasteful to set the background blur to the
exact same value multiple times.

Bug: 881134
Change-Id: I3762c486385d9136f1aea3e50d1e304d69aef141
Reviewed-on: https://chromium-review.googlesource.com/1233122
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592408}(cherry picked from commit 15020b8f5d62bd73aa871b2fa50f1ccee4c37125)
Reviewed-on: https://chromium-review.googlesource.com/1241560
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#601}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/429731975a4d5b6dea20eaf9eab9296195f5418a/ash/shelf/shelf_widget.cc

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/429731975a4d5b6dea20eaf9eab9296195f5418a

Commit: 429731975a4d5b6dea20eaf9eab9296195f5418a
Author: manucornet@chromium.org
Commiter: newcomer@chromium.org
Date: 2018-09-24 21:18:48 +0000 UTC

CrOS Shelf: Set background blur only once

This does not fix any known issues (and in fact doesn't change any
behavior), but it seems wasteful to set the background blur to the
exact same value multiple times.

Bug: 881134
Change-Id: I3762c486385d9136f1aea3e50d1e304d69aef141
Reviewed-on: https://chromium-review.googlesource.com/1233122
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592408}(cherry picked from commit 15020b8f5d62bd73aa871b2fa50f1ccee4c37125)
Reviewed-on: https://chromium-review.googlesource.com/1241560
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#601}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Labels: -M-70
I still found this issue with 71.0.3565.0 OS, could I which OS version fix this issue?
Cc: kejiashao@chromium.org
 Issue 895534  has been merged into this issue.
All, this continues to be an issue - and will be seen by users on M-71.
We also have a few devices FSI-ing on M-71. Will this be fixed in M71 ?
Owner: wutao@chromium.org
Status: Started (was: Assigned)
Assign this myself. Working on a fix now.
Owner: manucornet@chromium.org
I uploaded a testing cl to [1].
This cl has not fixed all the things yet. Just approve that during animation the blur can be applied.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1299698


Due to the urgent and complexity of this bug, assign it back to the Shelf expert.
I'm trying to do this in a slightly simpler way. Current CL is at:

    https://chromium-review.googlesource.com/c/chromium/src/+/1300691

And I'm attaching a screencast. I think this looks good.
shelf_blur.mp4
1.6 MB View Download
Ok there's been a few attempts at these and it's harder than it looks because of all the mask/layer/opacity/blur stuff. I think it's wise to spend some time understanding and sanitizing all that in time for M-72 rather than rush something. Still debating whether this is bad enough to really need a fix in M-71, but I'm thinking it would be wise to do all this more calmly.
Labels: -M-71 M-72
Labels: -Pri-1 Pri-2
FYI trying to simplify the layer structure and hopefully get to the bottom of this. Pending CL 1344997
Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.
Issue 917609 has been merged into this issue.

Sign in to add a comment