Second finger press or long press during swiping up on the shelf |
|||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome What steps will reproduce the problem? (1) In tablet mode, open at least one window (2) swipe up on the shelf. The window should be pushed upward, while the home launcher should be pulled up from the shelf (3) Use a second finger to press or long press during dragging What is the expected result? It should have no issue to do so What happens instead? Sometimes the chrome crashes. Sometimes the app list was disappeared. Sometimes the pushed-up window stuck in the middle, and swiping down on the top of launcher shows black background Sammie, please reassign if you're not a good owner
,
Sep 18
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74 commit 3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74 Author: Sammie Quon <sammiequon@google.com> Date: Wed Sep 19 17:29:10 2018 applist: Fix crash when swipe to show launcher with two fingers. Do not allow app list or its childrens to process events during swipe to close. Cancel swipe to close non scroll/fling event on shelf is seen. Search box widget can still take events on app list, this does not seem to cause any problems, but may need investigating. Also added a test to check local variables get reset after swiping in HomeLauncherGestureHandler. Test: ash_unittest *HomeLauncher*GestureHandlerTest* Bug: 881131 Change-Id: Id0e49e8fc246837900dc1145af12608b5e507874 Reviewed-on: https://chromium-review.googlesource.com/1233193 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592455} [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/app_list_controller_impl.h [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/app_list_view_delegate.h [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/home_launcher_gesture_handler.cc [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/home_launcher_gesture_handler.h [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/home_launcher_gesture_handler_unittest.cc [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/test/app_list_test_view_delegate.cc [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/test/app_list_test_view_delegate.h [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/app_list/views/app_list_view.h [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/3ab9f4eace94749c23a6f8ff659e1c4ae8fafb74/ash/shell/app_list.cc
,
Sep 19
|
|||
►
Sign in to add a comment |
|||
Comment 1 by newcomer@chromium.org
, Sep 6