find_shortcut_behavior.js runtime error with Polymer 2 |
||||||
Issue descriptionWhat steps will reproduce the problem? 1) Launch chrome with --enable-features=WebUIPolymer2 2) Visit chrome://settings/searchEngines (either directly or from chrome://settings) What is the expected result? No error. What happens instead? An assertion error is thrown consistently. See screenshot.
,
Sep 5
,
Sep 5
,
Sep 5
,
Sep 6
This error also causes CrSettingsSubpageTest.All to fail for Polymer 2 as noted in https://crbug.com/875452 . Altering the settings-subpage |active_| change observer into a compound observer |onActiveChangted(active_, searchLabel)| will also cause this test to fail.
,
Sep 6
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bd36f3e428e4301a476d081429fbb278794d357 commit 4bd36f3e428e4301a476d081429fbb278794d357 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Sep 06 21:07:21 2018 Settings WebUI: prevent settings-subpage from removing itself as a FindShortcutListener if it was not already added as one. Ensure |active_| has changed value and change onActiveChanged_ observer to a compound observer that also depends on |searchLabel| to ensure |searchLabel| has been initialized. Bug: 881104 Change-Id: Icf4e740c766d1069aba9da13b25879c95a1959eb Reviewed-on: https://chromium-review.googlesource.com/1208822 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#589297} [modify] https://crrev.com/4bd36f3e428e4301a476d081429fbb278794d357/chrome/browser/resources/settings/settings_page/settings_subpage.js
,
Sep 6
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Sep 5