New issue
Advanced search Search tips

Issue 881101 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 812037



Sign in to add a comment

Enable demo mode by default and remove flag

Project Member Reported by michae...@chromium.org, Sep 5

Issue description

Remove --enable-demo-mode flag and always enable Demo Mode when ARC++
is supported.

This has landed but needs to be merged into M70: 


The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edaa5e8c0a20af0e78184d1d85b08268becd94c4

commit edaa5e8c0a20af0e78184d1d85b08268becd94c4
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Fri Aug 31 04:27:27 2018

Enable demo mode by default and remove flag

Remove --enable-demo-mode flag and always enable Demo Mode when ARC++
is supported.

The --enable-offline-demo-mode flag will be removed separately for ease
of reverting in case that feature ends up being delayed.

Bug: 812037
Change-Id: Ie3ac7a98af21d3fab3e3c7f2aaff0c71a2bcaf08
Reviewed-on: https://chromium-review.googlesource.com/1195116
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587941}
[modify] https://crrev.com/edaa5e8c0a20af0e78184d1d85b08268becd94c4/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/edaa5e8c0a20af0e78184d1d85b08268becd94c4/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/edaa5e8c0a20af0e78184d1d85b08268becd94c4/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/edaa5e8c0a20af0e78184d1d85b08268becd94c4/chromeos/chromeos_switches.cc
[modify] https://crrev.com/edaa5e8c0a20af0e78184d1d85b08268becd94c4/chromeos/chromeos_switches.h

 
Labels: -Merge-Request-70
Labels: Merge-Request-70
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 7

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 10

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-70 merge-merged-3538
Status: Fixed (was: Started)
Messed up the bug number, but:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2340c50f02068d3a5b7c5507809d788491af554c

commit 2340c50f02068d3a5b7c5507809d788491af554c
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Fri Sep 14 01:12:07 2018

Enable demo mode by default and remove flag

Remove --enable-demo-mode flag and always enable Demo Mode when ARC++
is supported.

The --enable-offline-demo-mode flag will be removed separately for ease
of reverting in case that feature ends up being delayed.

Bug: 812037
Change-Id: Ie3ac7a98af21d3fab3e3c7f2aaff0c71a2bcaf08
Reviewed-on: https://chromium-review.googlesource.com/1195116
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587941}(cherry picked from commit edaa5e8c0a20af0e78184d1d85b08268becd94c4)

TBR=michaelpg@chromium.org

Change-Id: Ie3ac7a98af21d3fab3e3c7f2aaff0c71a2bcaf08
Reviewed-on: https://chromium-review.googlesource.com/1226170
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#396}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/2340c50f02068d3a5b7c5507809d788491af554c/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/2340c50f02068d3a5b7c5507809d788491af554c/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/2340c50f02068d3a5b7c5507809d788491af554c/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/2340c50f02068d3a5b7c5507809d788491af554c/chromeos/chromeos_switches.cc
[modify] https://crrev.com/2340c50f02068d3a5b7c5507809d788491af554c/chromeos/chromeos_switches.h

Sign in to add a comment