New issue
Advanced search Search tips

Issue 881086 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

org.chromium.chrome.browser.browseractions.BrowserActionActivityTest#testOpenSingleTabInBackgroundWhenChromeAvailable fails on Android M

Project Member Reported by pkotw...@chromium.org, Sep 5

Issue description

Failure on bot: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936189857945438016/+/steps/chrome_public_test_apk_on_Android_device_Nexus_5X__experimental_/0/stdout

Test output:

C  208.970s Main  ********************************************************************************
C  208.970s Main  Detailed Logs
C  208.971s Main  ********************************************************************************
C  208.971s Main  [FAIL] org.chromium.chrome.browser.browseractions.BrowserActionActivityTest#testOpenSingleTabInBackgroundWhenChromeAvailable:
C  208.971s Main  java.lang.AssertionError
C  208.971s Main  	at org.junit.Assert.fail(Assert.java:86)
C  208.971s Main  	at org.junit.Assert.assertTrue(Assert.java:41)
C  208.971s Main  	at org.junit.Assert.assertFalse(Assert.java:64)
C  208.971s Main  	at org.junit.Assert.assertFalse(Assert.java:74)
C  208.971s Main  	at org.chromium.chrome.browser.browseractions.BrowserActionActivityTest.testOpenSingleTabInBackgroundWhenChromeAvailable(BrowserActionActivityTest.java:398)
C  208.971s Main  	at java.lang.reflect.Method.invoke(Native Method)
C  208.971s Main  	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
C  208.971s Main  	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
C  208.971s Main  	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
C  208.971s Main  	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
C  208.971s Main  	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
C  208.971s Main  	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
C  208.971s Main  	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
C  208.972s Main  	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:116)
C  208.972s Main  	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
C  208.972s Main  	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
C  208.972s Main  	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:116)
C  208.972s Main  	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
C  208.972s Main  	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
C  208.972s Main  	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
C  208.972s Main  	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
C  208.972s Main  	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
C  208.972s Main  	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
C  208.972s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
C  208.972s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
C  208.972s Main  	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
C  208.972s Main  	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
C  208.972s Main  	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
C  208.972s Main  	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
C  208.972s Main  	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
C  208.972s Main  	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
C  208.972s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
C  208.972s Main  	at org.junit.runners.Suite.runChild(Suite.java:128)
C  208.973s Main  	at org.junit.runners.Suite.runChild(Suite.java:27)
C  208.973s Main  	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
C  208.973s Main  	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
C  208.973s Main  	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
C  208.973s Main  	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
C  208.973s Main  	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
C  208.973s Main  	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
C  208.973s Main  	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
C  208.973s Main  	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
C  208.973s Main  	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
C  208.973s Main  	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
C  208.973s Main  	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:125)
C  208.973s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
C  208.973s Main  
C  208.973s Main  Searching for native crashes in: /tmp/tmpYC_imN
C  208.973s Main  Unknown Android release, consider passing --packed-lib.
C  208.973s Main  Reading Android symbols from: /usr/local/google/home/pkotwicz/clankium/src
C  208.973s Main  Searching for Chrome symbols from within: /usr/local/google/home/pkotwicz/clankium/src/out/gn_Debug/lib.unstripped:/usr/local/google/home/pkotwicz/clankium/src/out/gn_Debug
C  208.973s Main  ********************************************************************************
C  208.973s Main  Summary
C  208.974s Main  ********************************************************************************
C  208.974s Main  [==========] 1 test ran.
C  208.974s Main  [  PASSED  ] 0 tests.
C  208.974s Main  [  FAILED  ] 1 test, listed below:
C  208.974s Main  [  FAILED  ] org.chromium.chrome.browser.browseractions.BrowserActionActivityTest#testOpenSingleTabInBackgroundWhenChromeAvailable
C  208.974s Main  
C  208.974s Main  1 FAILED TEST
C  208.974s Main  ********************************************************************************

 
Labels: -Pri-3 OS-Android Pri-1
Owner: arthurso...@chromium.org
Status: Assigned (was: Untriaged)
A manual bisect revealed that the failure started occuring as a result of https://chromium-review.googlesource.com/1201845

Cc: lizeb@chromium.org
I am taking a look. Thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33eb0779779e281bac7609f94842463c3f8f2ee0

commit 33eb0779779e281bac7609f94842463c3f8f2ee0
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Wed Sep 12 07:21:49 2018

Reland: Remove SeparateTaskCustomTabActivity for Android version > L.

Cause of revert:
===============
BrowserActionActivityTest#testOpenSingleTabInBackgroundWhenChromeAvailable was
failing.

LaunchIntentDispatcher was no more forcing the flag:
FLAG_ACTIVITY_NEW_DOCUMENT.

Original description:
=====================
Remove SeparateTaskcustomTabActivity for Android version > L.

Make SeparateTaskcustomTabActivity to be used only for Android version
pre L. The part used for Android version >= L is merged into
CustomTabActivity.

This is a prerequisite for skipping the ChromeLauncherActivity and
directly launch the CustomTabActivity.

Bug: 681559,  881086 
Change-Id: I0135b0c8f217ebe528e85ddf7e047483fe07a156
Reviewed-on: https://chromium-review.googlesource.com/1213002
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590611}
[modify] https://crrev.com/33eb0779779e281bac7609f94842463c3f8f2ee0/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/33eb0779779e281bac7609f94842463c3f8f2ee0/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
[modify] https://crrev.com/33eb0779779e281bac7609f94842463c3f8f2ee0/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/33eb0779779e281bac7609f94842463c3f8f2ee0/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskCustomTabActivity.java
[modify] https://crrev.com/33eb0779779e281bac7609f94842463c3f8f2ee0/chrome/android/javatests/src/org/chromium/chrome/browser/media/MediaLauncherActivityTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment