New issue
Advanced search Search tips

Issue 881080 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Team-Accessibility



Sign in to add a comment

Programmatically determine what actions SwitchAccess can perform on a given node

Project Member Reported by zhelfins@chromium.org, Sep 5

Issue description

Currently the set of options for each node is the same, and it's hard-coded. We want it to be customized per-element based on the properties of the node.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20dc1b05189c626db3d44bad573b4c804c4e3a36

commit 20dc1b05189c626db3d44bad573b4c804c4e3a36
Author: Anastasia Helfinstein <anastasi@google.com>
Date: Sat Jan 05 02:29:46 2019

Refactor SwitchAccessPredicate

Revamps the file-level comment to detail available functions. Re-orders
the methods in switch_access_predicate.js for clarity. Also updates
comments and names of methods to focus on intended behavior over
implementation details.

This is a pure refactor, with no change to functionality.

Bug:  881080 
Change-Id: I612869926fb2656c5fe2d9d8841817ebb752ff5b
Reviewed-on: https://chromium-review.googlesource.com/c/1394921
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#620157}
[modify] https://crrev.com/20dc1b05189c626db3d44bad573b4c804c4e3a36/chrome/browser/resources/chromeos/switch_access/navigation_manager.js
[modify] https://crrev.com/20dc1b05189c626db3d44bad573b4c804c4e3a36/chrome/browser/resources/chromeos/switch_access/switch_access_predicate.js
[modify] https://crrev.com/20dc1b05189c626db3d44bad573b4c804c4e3a36/chrome/browser/resources/chromeos/switch_access/switch_access_predicate_test.extjs
[modify] https://crrev.com/20dc1b05189c626db3d44bad573b4c804c4e3a36/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter

Cc: -zhelfins@chromium.org
Labels: -Pri-3 Pri-2
Owner: anastasi@google.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d1ba39391b983be6b36011ba033a2dd5de9a62b

commit 8d1ba39391b983be6b36011ba033a2dd5de9a62b
Author: Anastasia Helfinstein <anastasi@google.com>
Date: Fri Jan 11 00:25:20 2019

Determine relevant menu items for Switch Access Context Menu programatically.

Also changes method of identifying text inputs (for the purposes of
determining actionability) to use roles, rather than the existence of an
input_type.

Bug:  881080 
Change-Id: I67b25c37423e20eb8774e32fa8784ad6be6243ad
Reviewed-on: https://chromium-review.googlesource.com/c/1401266
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621823}
[modify] https://crrev.com/8d1ba39391b983be6b36011ba033a2dd5de9a62b/chrome/browser/resources/chromeos/switch_access/context_menu_manager.js
[modify] https://crrev.com/8d1ba39391b983be6b36011ba033a2dd5de9a62b/chrome/browser/resources/chromeos/switch_access/switch_access_predicate.js

Status: Fixed (was: Started)

Sign in to add a comment