Add the following experiment parameters: 1) For top and bottom snackbar 2) Set stable offline wait time 3) Allow to bypass getting connectivity info from system and run our own http probes
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ade8283140ad07e584bf91ba9a153df5588531e0 commit ade8283140ad07e584bf91ba9a153df5588531e0 Author: Jian Li <jianli@chromium.org> Date: Thu Sep 06 22:31:41 2018 Add more parameters for offline indicator experiment The following parameters are added: 1) Select either top or bottom snackbar 2) Set stable offline wait time 3) Allow to bypass getting connectivity info from system and run our own http probes Bug: 881064 Change-Id: I72bbb82f2deb9f6222d25191380c048a53a4c815 Reviewed-on: https://chromium-review.googlesource.com/1208445 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#589344} [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/chrome/browser/about_flags.cc [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/chrome/browser/flag_descriptions.h [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/components/offline_pages/core/offline_page_feature.cc [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/components/offline_pages/core/offline_page_feature.h [modify] https://crrev.com/ade8283140ad07e584bf91ba9a153df5588531e0/tools/metrics/histograms/enums.xml
Verified in Canary 71.0.3545.0
Approved for merge into 70, branch 3538.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9bc436ffa134a41c863e28ed8fd6a3b380feb01 commit a9bc436ffa134a41c863e28ed8fd6a3b380feb01 Author: Jian Li <jianli@chromium.org> Date: Fri Sep 07 21:12:38 2018 Merge M70: Add more parameters for offline indicator experiment The following parameters are added: 1) Select either top or bottom snackbar 2) Set stable offline wait time 3) Allow to bypass getting connectivity info from system and run our own http probes TBR=jianli@chromium.org (cherry picked from commit ade8283140ad07e584bf91ba9a153df5588531e0) Bug: 881064 Change-Id: I72bbb82f2deb9f6222d25191380c048a53a4c815 Reviewed-on: https://chromium-review.googlesource.com/1208445 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589344} Reviewed-on: https://chromium-review.googlesource.com/1213514 Reviewed-by: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#167} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/chrome/browser/about_flags.cc [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/chrome/browser/flag_descriptions.h [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/components/offline_pages/core/offline_page_feature.cc [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/components/offline_pages/core/offline_page_feature.h [modify] https://crrev.com/a9bc436ffa134a41c863e28ed8fd6a3b380feb01/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, Sep 6