New issue
Advanced search Search tips

Issue 881061 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----


Participants' hotlists:
Launcher-Polish


Sign in to add a comment

Shelf shows rounded corners with window open during launcher drag

Project Member Reported by ginko@chromium.org, Sep 5

Issue description

Chrome Version: 70.0.3538.0
OS: ChromOS

What steps will reproduce the problem?
(1) Open a fullscreen window
(2) open launcher
(3) drag launcher closed, but don't release

What is the expected result?
Launcher appears to be closed, shelf is in square-cornered state because of the open window

What happens instead?
shelf shows rounded corners with an open, fullscreen window


Bonus Video:
https://photos.app.goo.gl/Y3JS4BKGrLsWb3Db6
 
Labels: M-70 Pri-1
Owner: manucornet@chromium.org
Labels: -M-70 M-71
It's a visible glitch but I wouldn't really say it's a show-stopper? Marking as P2. I may be able to fix it through other work on these animations but it's likely this will be in M-71.
Labels: -Pri-1 Pri-2
Status: Assigned (was: Untriaged)
Labels: m-72
Bulk moving all M-71 <P-1's to M-72.
Labels: -M-71 -m-71
Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.
Cc: manucornet@chromium.org
Owner: sgabr...@chromium.org
Sébastien, how should we address this? How should things behave in this case? In particular around when corners should remain rounded or square at various stages of this animation / drag process.
This is linked to bug 899289 I believe.
Because we did not show the shelf all the time at the time this bug was filed,
I believe that in the video when user drags the launcher, the full opaque shelf just disappears automatically. What should happen is:

-> User drags launcher
-> As long as Launcher top edge is positioned <=  112px (double shelf height), shelf corners morph to rounded (if possible), shelf remains opaque
-> When launcher passes the 112px threshold, we decrease opacity linearly so that the coloring layer of the shelf is set to 20% opacity once the launcher reaches 284px (peeking launcher height).

So in this case, if the user drags the launcher down passed the 112px threshold, the launcher will be 100% again, not holes will be visible.

Let me know if that makes sense. If not, I'll create a motion spec.
Owner: manucornet@chromium.org

Sign in to add a comment