New issue
Advanced search Search tips

Issue 881057 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-contain] Import Mozilla tests from WPT

Project Member Reported by r...@igalia.com, Sep 5

Issue description


Firefox contributes tests to WPT for css-contain spec in the following folder:
https://github.com/web-platform-tests/wpt/tree/master/css/vendor-imports/mozilla/mozilla-central-reftests/contain

It'd be nice to import them in Chromium too, so we can reuse tests and improve interoperability.

Check the following comment in a different issue for more information:
https://bugs.chromium.org/p/chromium/issues/detail?id=863454#c9
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c56f0be1edfcda3074c79f5130fa3c460f68b9da

commit c56f0be1edfcda3074c79f5130fa3c460f68b9da
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Thu Sep 06 19:55:49 2018

[css-contain] Import Mozilla tests from WPT

Firefox tests for css-contain spec are under
css/vendor-imports/mozilla/mozilla-central-reftests/contain/
in WPT.

This patch removes this folder as skipped from W3CImportExpectations
and does the first import of these tests.

BUG= 881057 

No-Export: true
Change-Id: Iabd132cdeea92d0fa6abdb233756952946803100
Reviewed-on: https://chromium-review.googlesource.com/1208051
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589254}
[modify] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-containing-block-absolute-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-containing-block-fixed-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-formatting-context-float-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-formatting-context-margin-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-formatting-context-margin-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-ignored-cases-no-principal-box-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-ignored-cases-no-principal-box-002-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-ignored-cases-no-principal-box-002.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-ignored-cases-no-principal-box-003-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-ignored-cases-no-principal-box-003.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-overflow-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-overflow-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-overflow-002-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-overflow-002.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-stacking-context-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-002-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-002.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-003-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-003.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-004-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-004.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-005.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-006-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-006.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-containing-block-absolute-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-containing-block-absolute-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-containing-block-fixed-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-containing-block-fixed-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-formatting-context-float-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-formatting-context-float-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-formatting-context-margin-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-formatting-context-margin-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-internal-table-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-internal-table-001a.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-internal-table-001b.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-no-principal-box-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-no-principal-box-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-ruby-containing-block-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-ruby-containing-block-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-ruby-stacking-and-clipping-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-ignored-cases-ruby-stacking-and-clipping-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-stacking-context-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-stacking-context-001a.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-stacking-context-001b.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-block-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-block-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-button-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-button-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-002-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-002.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-flex-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-flex-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-inline-block-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-inline-block-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-inline-flex-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-inline-flex-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-multicol-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-multicol-001.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-multicol-002-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-multicol-002.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-multicol-003-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-multicol-003.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-table-caption-001-ref.html
[add] https://crrev.com/c56f0be1edfcda3074c79f5130fa3c460f68b9da/third_party/WebKit/LayoutTests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-table-caption-001.html

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f67ff8b4f9f9deb5d72e682e3ba54c32191ac75d

commit f67ff8b4f9f9deb5d72e682e3ba54c32191ac75d
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Dec 05 11:03:55 2018

Remove failure expectations for passing wpt/css/ tests.

css-text/word-break/word-break-normal-km-000.html only fails on Windows.

vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-button-001.html
doesn't fail anywhere.

TBR=kojii@chromium.org,rego@igalia.com

Bug:  881057 
Change-Id: I36517e192c10ad1403a7c7cee9143b746ceee641
Reviewed-on: https://chromium-review.googlesource.com/c/1361100
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613934}
[modify] https://crrev.com/f67ff8b4f9f9deb5d72e682e3ba54c32191ac75d/third_party/blink/web_tests/TestExpectations

Sign in to add a comment