There are multiple issues her which I believed to be tracked on various bus:

- Rounded corners: bug 874183 (which appears to be fixed, regression)
- Left/right margin: bug 876474
- Regarding the icon alignment, we can only maintain alignment until it reaches the side of the screen, in which case the icons will be pushed by and amount of padding different than the one required for the icons to be aligned

On last thing, the overflow background should never be cut off, the icons should just be cropped on the right side by the overflow background, which remains 8dp from screen left and right.

Probably a P-1?

Sammie is taking a look at bug 808237 which I think will likely at least slightly improve things for this one. So it's probably smart for me to wait and see what happens there before spending time on this. Sammie, what do you think?

re c#4 - That one is trying to land https://chromium-review.googlesource.com/c/chromium/src/+/1208826.

IIUC from c#1 we still need paddings from the edges of the screen, which looks like issue 876474, so feel free to close this bug if you agree :)

Ok so it sounds like the best way to fix this is

1) Enforce a maximum width (or height) for the overflow menu so that it leaves some padding around it even if it fills the screen

2) Make the menu scrollable

So the logical thing seems to be for me to do 1) while Sammie is doing 2). Let me know if I'm missing something :-)

Yeah that sgtm. 2) just landed and you can probably do 1) pretty quickly altering [1] fyi.

[1] https://cs.chromium.org/chromium/src/ash/shelf/overflow_bubble_view.cc?rcl=17957e83e387cb9bce164932fa3fa02cafdeaffb&l=184

Attaching some before/after screenshots for the current ongoing CLs.

Deleted: 1_before_h.png 330 KB

	1_before_h.png 330 KB View Download

Deleted: 2_after_h.png 350 KB

	2_after_h.png 350 KB View Download

Deleted: 3_before_v.png 372 KB

	3_before_v.png 372 KB View Download

Deleted: 4_after_v.png 372 KB

	4_after_v.png 372 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a53cb4c0e9d2489c4f2534d5db0d912f4343a6d8

commit a53cb4c0e9d2489c4f2534d5db0d912f4343a6d8
Author: Manu Cornet <manucornet@chromium.org>
Date: Fri Sep 07 16:44:01 2018

CrOS Shelf: Ensure a minimum margin around the overflow bubble

See some before/after screenshots here:

    https://bugs.chromium.org/p/chromium/issues/detail?id=881043#c8

Note that this also introduces the same margin in the "old" UI, but
this is a desired side effect.

Bug:  881043 , 876474
Change-Id: Iddd8dd701076d3a2e230e841eba5eec467a94882
Reviewed-on: https://chromium-review.googlesource.com/1212092
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589545}
[modify] https://crrev.com/a53cb4c0e9d2489c4f2534d5db0d912f4343a6d8/ash/shelf/overflow_bubble_view.cc

Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d75fa817d8d3e0c3461adff8b04da20d439d4728

commit d75fa817d8d3e0c3461adff8b04da20d439d4728
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Sep 13 22:33:31 2018

CrOS Shelf: Ensure a minimum margin around the overflow bubble

See some before/after screenshots here:

    https://bugs.chromium.org/p/chromium/issues/detail?id=881043#c8

Note that this also introduces the same margin in the "old" UI, but
this is a desired side effect.

TBR=manucornet@chromium.org

(cherry picked from commit a53cb4c0e9d2489c4f2534d5db0d912f4343a6d8)

Bug:  881043 , 876474
Change-Id: Iddd8dd701076d3a2e230e841eba5eec467a94882
Reviewed-on: https://chromium-review.googlesource.com/1212092
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589545}
Reviewed-on: https://chromium-review.googlesource.com/1226255
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#390}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/d75fa817d8d3e0c3461adff8b04da20d439d4728/ash/shelf/overflow_bubble_view.cc