Fix autocomplete interaction with left/right keys. |
|||
Issue descriptionAutocomplete feature currently resets text after each arrow keypress, regardless of if there is a suggestion or not, causing unwanted interactions. Fix: Handle arrow keys only if there is currently autocomplete text in AppList search box.
,
Sep 6
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81ac5803ecec7d4b1181a37a1cb83f8c07109d3d commit 81ac5803ecec7d4b1181a37a1cb83f8c07109d3d Author: Daniel Zhang <oxyflush@google.com> Date: Fri Sep 07 18:05:55 2018 cros: Fix autocomplete interaction with arrow keys Currently, AppList autocomplete feature handles arrow key events regardless of whether or not there is autocomplete text present, causing unwanted interactions. Change autocomplete so that it only handles arrow keys when autocomplete text is present. Bug: 881039 Change-Id: I7041646e87e5cd4e95d6299017fa2259899f8994 Reviewed-on: https://chromium-review.googlesource.com/1208718 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#589582} [modify] https://crrev.com/81ac5803ecec7d4b1181a37a1cb83f8c07109d3d/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/81ac5803ecec7d4b1181a37a1cb83f8c07109d3d/ash/app_list/views/search_box_view.h
,
Sep 7
|
|||
►
Sign in to add a comment |
|||
Comment 1 by oxyflush@chromium.org
, Sep 6