New issue
Advanced search Search tips

Issue 881036 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 880827



Sign in to add a comment

test_installer test_chrome_with_chromedriver failing on Windows ThinLTO bot

Project Member Reported by inglorion@chromium.org, Sep 5

Issue description

Example failing build:
https://ci.chromium.org/buildbot/chromium.clang/ToTWinThinLTO64/1788

Logs:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTWinThinLTO64%2F1788%2F%2B%2Frecipes%2Fsteps%2Ftest_installer%2F0%2Fstdout

Excerpt:
======================================================================
ERROR: ChromeUserLevel: no_pv -> install_chrome_user -> chrome_user_installed_not_inuse -> test_chrome_with_chromedriver_user -> chrome_user_installed_not_inuse -> uninstall_chrome_user -> clean
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\b\c\b\ToTWinThinLTO64\src\chrome\test\mini_installer\test_installer.py", line 156, in runTest
    self._config.actions[action], self._variable_expander)
  File "C:\b\c\b\ToTWinThinLTO64\src\chrome\test\mini_installer\test_installer.py", line 231, in RunCommand
    expanded_command, returncode))
Exception: Command python test_chrome_with_chromedriver.py --chromedriver-path="C:\b\c\b\ToTWinThinLTO64\src\out\Release_x64\chromedriver.exe"  "C:\Users\chrome-bot\AppData\Local\Google\Chrome\Application\chrome.exe" returned non-zero exit status 1

 
Cc: r...@chromium.org h...@chromium.org
It's not yet clear what the first failing build is, because going back in history we get to builds that failed in the compile step.

Build 1741 is the earliest that reported the failure. That one used crrev.com/585446 and Clang revision 340525.
Recompiled with Clang rev 338148, seems to work fine. Bisecting further.
First bad rev appears to be 338767 "Set IsUsedInRegularObj in a consistent manor between COFF, ELF and wasm.  NFC".
Labels: Needs-Milestone
The problem seems to be that we always set IsUsedInRegularObj to true in addLazy(), whereas we did not previously do so.
Owner: inglorion@chromium.org
Status: Assigned (was: Unconfirmed)
Never trust an "NFC" change :-) Nice debugging!
Status: Verified (was: Assigned)
Fixed in Clang 341585.
Blockedon: 880827

Sign in to add a comment