New issue
Advanced search Search tips

Issue 881022 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain

Blocking:
issue 878565



Sign in to add a comment

kevin64 build failure in Chrome widevinecdm

Project Member Reported by manojgupta@chromium.org, Sep 5

Issue description

Seems like widevince cdm can't be built for arm64.

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8936230431353563024

chromeos-chrome-70.0.3538.0_rc-r1: Running hooks: 100% (76/76), done.
chromeos-chrome-70.0.3538.0_rc-r1:  * GN_ARGS = is_debug=false  use_v4l2_codec=true use_v4lplugin=true use_vaapi=false use_ozone=true use_evdev_gestures=true use_xkbcommon=true linux_use_bundled_binutils=false use_debug_fission=false enable_remoting=true enable_nacl=false icu_use_data_file=true use_cras=true use_system_harfbuzz=false use_system_freetype=false use_system_libsync=true use_cups=true use_jumbo_build=false use_bundled_fontconfig=false is_asan=false is_clang=true cros_host_is_clang=true cros_v8_snapshot_is_clang=true clang_use_chrome_plugins=false use_thin_lto=true use_lld=false is_cfi=true use_cfi_cast=true ozone_auto_platforms=false ozone_platform_gbm=true use_system_minigbm=true use_system_libdrm=true is_chrome_branded=true is_official_build=true internal_gles2_conform_tests=true treat_warnings_as_errors=false use_goma=true use_debug_fission=true symbol_level=2 target_sysroot="/build/kevin64" system_libdir="lib64" pkg_config="/build/kevin64/build/bin/pkg-config" target_os="chromeos" host_pkg_config="x86_64-pc-linux-gnu-pkg-config" ozone_platform="gbm" target_cpu="arm64" arm_arch="armv8-a+crc" goma_dir="/home/chrome-bot/goma" cros_target_ar="llvm-ar" cros_target_cc="aarch64-cros-linux-gnu-clang -B/usr/x86_64-pc-linux-gnu/aarch64-cros-linux-gnu/binutils-bin/2.27.0-gold" cros_target_cxx="aarch64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/aarch64-cros-linux-gnu/binutils-bin/2.27.0-gold" host_toolchain="//build/toolchain/cros:host" custom_toolchain="//build/toolchain/cros:target" v8_snapshot_toolchain="//build/toolchain/cros:v8_snapshot" cros_target_ld="aarch64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/aarch64-cros-linux-gnu/binutils-bin/2.27.0-gold" cros_target_nm="aarch64-cros-linux-gnu-nm" cros_target_extra_cflags="-pipe -march=armv8-a+crc -mtune=cortex-a57 -ftree-vectorize -fno-split-dwarf-inlining -fdebug-info-for-profiling -Wno-unknown-warning-option -fprofile-sample-use=/build/kevin64/tmp/portage/chromeos-base/chromeos-chrome-70.0.3538.0_rc-r1/work/afdo/silvermont_R70-3497.35-1535364250.afdo -Wno-error" cros_target_extra_cppflags="" cros_target_extra_cxxflags="-pipe -march=armv8-a+crc -mtune=cortex-a57 -ftree-vectorize -fno-split-dwarf-inlining -fdebug-info-for-profiling -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -stdlib=libc++ -fprofile-sample-use=/build/kevin64/tmp/portage/chromeos-base/chromeos-chrome-70.0.3538.0_rc-r1/work/afdo/silvermont_R70-3497.35-1535364250.afdo -Wno-error" cros_target_extra_ldflags="-Wl,-O1 -Wl,-O2 -Wl,--as-needed -stdlib=libc++ -Wl,-plugin-opt,-import-instr-limit=30" cros_host_cc="x86_64-pc-linux-gnu-clang -B/usr/bin" cros_host_cxx="x86_64-pc-linux-gnu-clang++ -B/usr/bin" cros_host_ar="llvm-ar" cros_host_ld="x86_64-pc-linux-gnu-clang++" cros_host_nm="x86_64-pc-linux-gnu-nm" cros_host_extra_cflags=" -Wno-unknown-warning-option" cros_host_extra_cxxflags=" -Wno-unknown-warning-option" cros_host_extra_cppflags="" cros_host_extra_ldflags="" cros_v8_snapshot_cc="x86_64-pc-linux-gnu-clang -B/usr/bin" cros_v8_snapshot_cxx="x86_64-pc-linux-gnu-clang++ -B/usr/bin" cros_v8_snapshot_ar="llvm-ar" cros_v8_snapshot_ld="x86_64-pc-linux-gnu-clang++" cros_v8_snapshot_nm="x86_64-pc-linux-gnu-nm" cros_v8_snapshot_extra_cflags=" -Wno-unknown-warning-option" cros_v8_snapshot_extra_cxxflags=" -Wno-unknown-warning-option" cros_v8_snapshot_extra_cppflags="" cros_v8_snapshot_extra_ldflags=""
chromeos-chrome-70.0.3538.0_rc-r1: Done. Made 11119 targets from 1874 files in 6009ms
chromeos-chrome-70.0.3538.0_rc-r1: >>> Source configured.
chromeos-chrome-70.0.3538.0_rc-r1: >>> Compiling source in /build/kevin64/tmp/portage/chromeos-base/chromeos-chrome-70.0.3538.0_rc-r1/work/chromeos-chrome-70.0.3538.0_rc ...
chromeos-chrome-70.0.3538.0_rc-r1: ninja: Entering directory `c/Release'
chromeos-chrome-70.0.3538.0_rc-r1: ninja: error: '../../../../../../../home/chrome-bot/chrome_root/src/third_party/widevine/cdm/chromeos/arm64/widevine_cdm_version.h', needed by 'gen/widevine_cdm_version.h', missing and no known rule to make it
chromeos-chrome-70.0.3538.0_rc-r1:  * ERROR: chromeos-base/chromeos-chrome-70.0.3538.0_rc-r1::chromiumos failed (compile phase):
 
Components: Tools>ChromeOS-Toolchain
Cc: vapier@chromium.org xhw...@chromium.org ihf@chromium.org mnissler@chromium.org
Components: Internals>Media>Encrypted
Owner: hmchen@chromium.org
Haoming, I am trying to bring up ARM64 userspace and the builds are failing because of missing widevinecdm files for arm64.

Do you know how hard would be to provide widevinecdm libraries for arm64 builds? I can't seem to find a way to build it myself.
Cc: hmchen@chromium.org
Owner: xhw...@chromium.org
Status: Assigned (was: Untriaged)
Xiaohan, it looks related to you CL removing the widevine_cdm_version.h file. Can you take a look?
This is not related to widevine_cdm_version.h change. Rather, it's simply because we never have arm64 build, so that src/third_party/widevine/cdm/chromeos/arm64 doesn't exist at all.

manojgupta: What's the plan on arm64? Do you need Widevine CDM support and if so, when?

I'll comment on your CL about a quick fix to avoid the build error.
While we'll need support for Widevine CDM eventually, support is not needed in short term since we most likely won't be shipping arm64 userspace based Chrome OS to customers before 2020.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db92b9a344716ff822424da764435b11aa62408a

commit db92b9a344716ff822424da764435b11aa62408a
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Sep 10 18:13:38 2018

media: Disable widevine cdm for Linux arm64 builds.

Currently there are no widevine cdm libraries for arm64 builds.
Disable it to avoid build errors when building ARM64 Chrome
in Chrome OS.

Bug:  881022 
Test: No more missing widevinecdm files errors.
Change-Id: I476415cef0c435cb50e113de4e576cb6d3006951
Reviewed-on: https://chromium-review.googlesource.com/1211974
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589983}
[modify] https://crrev.com/db92b9a344716ff822424da764435b11aa62408a/third_party/widevine/cdm/widevine.gni

xhwang@, hmchen@: My Cl only updated the code in //third_party/widevine. Do you know if a DEPS roll is needed as well. if so, can you do it for me?
manojgupta: No DPES roll is needed for this change.

With that can we mark this as fixed? 
Owner: manojgupta@chromium.org
Status: Fixed (was: Assigned)
Thanks, marking as fixed. Still waiting for Chrome uprev in Chrome OS to happen for verified status.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2e3715b91731535eb1860ce304a40f2072bf2769

commit 2e3715b91731535eb1860ce304a40f2072bf2769
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Sep 19 15:59:30 2018

chrome_util: Make widevine cdm optional for ARM64.

No prebuilt widevince cdm is available for arm64 yet.
So make it optional so that deploy_chrome does not complain
about missing widevine cdm library.

BUG= chromium:881022 
TEST=Chrome (finally) builds in kevin64-release.

Change-Id: I4c1c240205483e7c6d79f5737951c764a5fc68d4
Reviewed-on: https://chromium-review.googlesource.com/1232557
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2e3715b91731535eb1860ce304a40f2072bf2769/lib/chrome_util.py

Sign in to add a comment