New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 881021 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in CanSubclassHaveInobjectProperties(instance_type) in objects.cc

Project Member Reported by ClusterFuzz, Sep 5

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5908377495142400

Fuzzer: inferno_js_fuzzer
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  CanSubclassHaveInobjectProperties(instance_type) in objects.cc
  v8::platform::PrintStackTrace
  v8::internal::JSFunction::GetDerivedMap
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=55626:55627

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5908377495142400

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 5

Cc: usharma1...@gmail.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

[intl] Port BreakIterator to C++ by usharma1998@gmail.com - https://chromium.googlesource.com/v8/v8/+/f2d07ec516fc069e93df4b2983cbd112a8ade3e9

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Labels: Pri-1
Owner: gsat...@chromium.org
Status: Assigned (was: Untriaged)
Probably a dupe of https://bugs.chromium.org/p/chromium/issues/detail?id=880697, or possibly similar.

Labels: Security_Impact-Head
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d2a85d10328ed42f8833833ff673348873c86151

commit d2a85d10328ed42f8833833ff673348873c86151
Author: Sathya Gunasekaran <gsathya@chromium.org>
Date: Thu Sep 06 07:10:10 2018

[Intl] Fix subclassing of V8BreakIterator

Bug:  v8:5751 ,  chromium:881021 
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I22514ceb5fb0953b728e67ba5266926e912ce9c1
Reviewed-on: https://chromium-review.googlesource.com/1208516
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55671}
[modify] https://crrev.com/d2a85d10328ed42f8833833ff673348873c86151/src/objects.cc
[add] https://crrev.com/d2a85d10328ed42f8833833ff673348873c86151/test/intl/break-iterator/subclass.js

Project Member

Comment 6 by sheriffbot@chromium.org, Sep 6

Labels: Target-70 M-70
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 6

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Stable
Status: Fixed (was: Started)
No idea why sheriffbot says this is a ReleaseBlock-Stable. The offending commit only made it to the current canary as per https://chromiumdash.appspot.com/commit/f2d07ec516fc069e93df4b2983cbd112a8ade3e9

The fix will make it Canary. I don't think there's any backmerge required here.
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 6

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 10 by ClusterFuzz, Sep 7

ClusterFuzz has detected this issue as fixed in range 55670:55671.

Detailed report: https://clusterfuzz.com/testcase?key=5908377495142400

Fuzzer: inferno_js_fuzzer
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  CanSubclassHaveInobjectProperties(instance_type) in objects.cc
  v8::platform::PrintStackTrace
  v8::internal::JSFunction::GetDerivedMap
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=55626:55627
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=55670:55671

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5908377495142400

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Sep 7

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5908377495142400 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 13

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment