New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 881001 link

Starred by 1 user
Status: Fixed
Owner:
█ wnwen@chromium.org
OOO until Feb 4th
Closed: Sep 12
Cc:
agrieve@chromium.org
pshmakov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Missing dependencies in android_deps

Project Member Reported by wnwen@chromium.org, Sep 5 
Run:
  rm -rf third_party/android_deps/libs/[!O]*
  tools/android/roll/android_deps/fetch_all.py --update-all
  git status

Expected:
  Nothing, since this should re-fetch all the deps that were already in the repo

Actual:
  Changes:
        modified:   DEPS                                              
        modified:   third_party/android_deps/BUILD.gn                          
        modified:   third_party/android_deps/additional_readme_paths.json          
        modified:   third_party/android_deps/libs/com_google_android_play_core/README.chromium
        modified:   third_party/android_deps/libs/com_google_android_play_core/cipd.yaml
        modified:   third_party/android_deps/libs/com_google_dagger_dagger/cipd.yaml
        modified:   third_party/android_deps/libs/com_google_dagger_dagger_compiler/cipd.yaml
        modified:   third_party/android_deps/libs/com_google_dagger_dagger_producers/cipd.yaml
        modified:   third_party/android_deps/libs/com_google_dagger_dagger_spi/README.chromium
        modified:   third_party/android_deps/libs/com_google_dagger_dagger_spi/cipd.yaml
        modified:   third_party/android_deps/libs/com_google_errorprone_javac_shaded/LICENSE
        modified:   third_party/android_deps/libs/com_google_googlejavaformat_google_java_format/README.chromium                                                                                     
        modified:   third_party/android_deps/libs/com_google_googlejavaformat_google_java_format/cipd.yaml
        modified:   third_party/android_deps/libs/com_google_guava_guava/README.chromium
        modified:   third_party/android_deps/libs/com_google_guava_guava/cipd.yaml
        modified:   third_party/android_deps/libs/com_squareup_javapoet/cipd.yaml
  Untracked:
        third_party/android_deps/libs/com_google_android_play_core/LICENSE
        third_party/android_deps/libs/com_google_code_findbugs_jsr305/
        third_party/android_deps/libs/com_google_dagger_dagger/OWNERS
        third_party/android_deps/libs/com_google_dagger_dagger_compiler/OWNERS
        third_party/android_deps/libs/com_google_dagger_dagger_producers/OWNERS
        third_party/android_deps/libs/com_google_dagger_dagger_spi/OWNERS
        third_party/android_deps/libs/com_google_errorprone_error_prone_annotations/
        third_party/android_deps/libs/com_google_errorprone_javac_shaded/OWNERS
        third_party/android_deps/libs/com_google_googlejavaformat_google_java_format/OWNERS
        third_party/android_deps/libs/com_google_guava_guava/OWNERS
        third_party/android_deps/libs/com_google_j2objc_j2objc_annotations/
        third_party/android_deps/libs/com_squareup_javapoet/OWNERS
        third_party/android_deps/libs/javax_annotation_jsr250_api/OWNERS
        third_party/android_deps/libs/javax_inject_javax_inject/OWNERS
        third_party/android_deps/libs/org_checkerframework_checker_compat_qual/
        third_party/android_deps/libs/org_codehaus_mojo_animal_sniffer_annotations/

Comment 1 by wnwen@chromium.org, Sep 5

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee303ae5f6b4236040d090405fe650cbe13fc4f5

commit ee303ae5f6b4236040d090405fe650cbe13fc4f5
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Sep 12 19:41:37 2018

Android: Add missing dependencies in android_deps

- Update license URLs in ChromiumDepGraph.groovy
- Create directory for custom licenses:
  //third_party/android_deps/licenses/
- Set correct LICENSE for com_google_android_play_core
- Add correct version of dagger's cipd.yml (2.17)
- Split out javax.inject from dagger in build.gradle
- Add quotes around cipd.yaml description to avoid interpreting : as a
  mapping

Run:
  rm -rf third_party/android_deps/libs/[!O]*
  tools/android/roll/android_deps/fetch_all.py --update-all

New Libraries (Dependencies that were previously missed):
- com_google_code_findbugs_jsr305
- com_google_errorprone_error_prone_annotations
- com_google_j2objc_j2objc_annotations
- org_checkerframework_checker_compat_qual
- org_codehaus_mojo_animal_sniffer_annotations

Bug:  881001 
Change-Id: I32467644f3d4b0899d31e97826ba5b2d019aa3dc
Reviewed-on: https://chromium-review.googlesource.com/1208462
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590790}
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/DEPS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/PRESUBMIT.py
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/BUILD.gn
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/additional_readme_paths.json
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/android_arch_core_common/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/android_arch_lifecycle_common/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/android_arch_lifecycle_runtime/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_animated_vector_drawable/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_appcompat_v7/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_cardview_v7/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_design/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_gridlayout_v7/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_leanback_v17/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_mediarouter_v7/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_multidex/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_palette_v7/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_preference_leanback_v17/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_preference_v14/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_preference_v7/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_recyclerview_v7/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_annotations/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_compat/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_core_ui/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_core_utils/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_fragment/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_media_compat/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_v13/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_v4/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_support_vector_drawable/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_android_support_transition/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_auth/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_auth_api_phone/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_auth_base/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_base/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_basement/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_cast/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_cast_framework/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_clearcut/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_fido/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_flags/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_gcm/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_iid/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_instantapps/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_location/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_phenotype/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_places_placereport/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_stats/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_tasks/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_vision/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_gms_play_services_vision_common/cipd.yaml
[copy] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_play_core/LICENSE
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_play_core/README.chromium
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_android_play_core/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_code_findbugs_jsr305/LICENSE
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_code_findbugs_jsr305/OWNERS
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_code_findbugs_jsr305/README.chromium
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_code_findbugs_jsr305/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger_compiler/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger_compiler/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger_producers/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger_producers/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger_spi/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger_spi/README.chromium
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_dagger_dagger_spi/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations/LICENSE
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations/OWNERS
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations/README.chromium
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations/cipd.yaml
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_errorprone_javac_shaded/LICENSE
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_errorprone_javac_shaded/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_errorprone_javac_shaded/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_googlejavaformat_google_java_format/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_googlejavaformat_google_java_format/README.chromium
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_googlejavaformat_google_java_format/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_guava_guava/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_guava_guava/README.chromium
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_guava_guava/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_j2objc_j2objc_annotations/LICENSE
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_j2objc_j2objc_annotations/OWNERS
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_j2objc_j2objc_annotations/README.chromium
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_google_j2objc_j2objc_annotations/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_squareup_javapoet/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/com_squareup_javapoet/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/javax_annotation_jsr250_api/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/javax_annotation_jsr250_api/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/javax_inject_javax_inject/OWNERS
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/javax_inject_javax_inject/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/org_checkerframework_checker_compat_qual/LICENSE
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/org_checkerframework_checker_compat_qual/OWNERS
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/org_checkerframework_checker_compat_qual/README.chromium
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/org_checkerframework_checker_compat_qual/cipd.yaml
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/org_codehaus_mojo_animal_sniffer_annotations/LICENSE
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/org_codehaus_mojo_animal_sniffer_annotations/OWNERS
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/org_codehaus_mojo_animal_sniffer_annotations/README.chromium
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/libs/org_codehaus_mojo_animal_sniffer_annotations/cipd.yaml
[rename] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/licenses/Android_SDK_License-December_9_2016.txt
[add] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/third_party/android_deps/licenses/Codehaus_License-2009.txt
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/tools/android/roll/android_deps/build.gradle
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/tools/android/roll/android_deps/buildSrc/src/main/groovy/BuildConfigGenerator.groovy
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/tools/android/roll/android_deps/buildSrc/src/main/groovy/ChromiumDepGraph.groovy
[modify] https://crrev.com/ee303ae5f6b4236040d090405fe650cbe13fc4f5/tools/android/roll/android_deps/fetch_all.py

Comment 3 by wnwen@chromium.org, Sep 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment