grunt: graphics_HwOverlays.video fails with "number of overlays is 1" |
|||
Issue descriptionversion: 71-11036.0.0 Looks like this test is configured to be skipped if the device doesn't support drm atomic. amdgpu supports drm atomic, but only exposes one primary plane (and no overlay planes). Since amdgpu doesn't expose enough planes to do overlay, this test should just be skipped. Logs here: https://stainless.corp.google.com/browse/chromeos-autotest-results/234150452-chromeos-test/
,
Sep 5
Perhaps we could enumerate the planes enumerated in the output of modetest -p. If there are no Overlay planes, then perhaps this could be used as a heuristic to skip the test.
,
Sep 18
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/82aaf153ac2623ea654124a5a9fa34b08262e4e0 commit 82aaf153ac2623ea654124a5a9fa34b08262e4e0 Author: Miguel Casas <mcasas@chromium.org> Date: Fri Sep 28 02:44:45 2018 autotest: count modetest planes and use it in graphics_HwOverlay This CL: - Adds two new methods to graphics_utils: get_modetest_planes() and get_max_num_available_drm_planes(). The latter uses the former to return the maximum number of overlay planes available in the system. - Teaches graphics_HwOverlays.py to skip the test if there's just two or less overlay planes, since in that case we don't have any overlays available to promote a DrawQuad to. Change-Id: I87abe951387d98567a21a9e95355aeaee1899bc0 Bug: 880988 Reviewed-on: https://chromium-review.googlesource.com/1222491 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Drew Davenport <ddavenport@chromium.org> [modify] https://crrev.com/82aaf153ac2623ea654124a5a9fa34b08262e4e0/client/site_tests/graphics_HwOverlays/graphics_HwOverlays.py [modify] https://crrev.com/82aaf153ac2623ea654124a5a9fa34b08262e4e0/client/cros/graphics/graphics_utils.py
,
Oct 4
These tests are no longer failing. Thanks!
,
Oct 4
\o/ |
|||
►
Sign in to add a comment |
|||
Comment 1 by mcasas@chromium.org
, Sep 5