New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 880984 link

Starred by 1 user
Status: Fixed
Owner:
sande...@chromium.org
Closed: Nov 8
Cc:
█ hbengali@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Add metrics to PepperVideoDecoderHost for resolution and hw vs sw usage.

Project Member Reported by dalecur...@chromium.org, Sep 5 
These metrics will help us understand the remainder of the pepper usage for video decoding and inform choices around VDA refactoring.

Hardware decoding means VideoDecodeAccelerator is used. Software decoding means VideoDecoderShim is being used.

Since PVDH doesn't get the frame resolution at configuration time, we'll need to record a metric for each frame with a new size and bucket that resolution by HW vs SW. Instead of bucketing a raw size we should use the resolution levels that hbengali@ determined for UKM:
~1080p
~1440p
~2160p or higher
~480p or lower
~720p

We might want a ~360p bucket as well. Initially tagging as M70 if it's not too invasive to merge back so we can get data sooner.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96732f5c82ad9dc79158807187ea743010c6d9c1

commit 96732f5c82ad9dc79158807187ea743010c6d9c1
Author: Dan Sanders <sandersd@chromium.org>
Date: Wed Nov 07 00:53:46 2018

Add Media.PepperVideoDecoderOutputPictureCount UMA

This UMA counts pictures output to Pepper clients, categorized by size
and decoder type (HW vs SW).

This will be used as a proxy for watch time / compute resources when
evaluating PPB_Video_Decoder deprecation.

Bug:  880984 
Change-Id: Ifac8de6ada9ae8a700dc61db91830307a99aa85c
Reviewed-on: https://chromium-review.googlesource.com/c/1306917
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605885}
[modify] https://crrev.com/96732f5c82ad9dc79158807187ea743010c6d9c1/content/renderer/pepper/pepper_video_decoder_host.cc
[modify] https://crrev.com/96732f5c82ad9dc79158807187ea743010c6d9c1/content/renderer/pepper/pepper_video_decoder_host.h
[modify] https://crrev.com/96732f5c82ad9dc79158807187ea743010c6d9c1/content/renderer/pepper/ppb_video_decoder_impl.cc
[modify] https://crrev.com/96732f5c82ad9dc79158807187ea743010c6d9c1/content/renderer/pepper/ppb_video_decoder_impl.h
[modify] https://crrev.com/96732f5c82ad9dc79158807187ea743010c6d9c1/media/base/media_util.cc
[modify] https://crrev.com/96732f5c82ad9dc79158807187ea743010c6d9c1/media/base/media_util.h
[modify] https://crrev.com/96732f5c82ad9dc79158807187ea743010c6d9c1/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/96732f5c82ad9dc79158807187ea743010c6d9c1/tools/metrics/histograms/histograms.xml

Comment 2 by sande...@chromium.org, Nov 8

Status: Fixed (was: Assigned)
Verified that CRD increments Media.PepperVideoDecoderOutputPictureCount.SW on Mac OS X.
►

Sign in to add a comment