New issue
Advanced search Search tips

Issue 880983 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Support <path()> for 'clip-path'

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Sep 5

Issue description

WPT import https://crrev.com/c/1207214 introduced new failures in external/wpt/css/css-masking:

List of new failures:
external/wpt/css/css-masking/clip-path/clip-path-path-002.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-path-001.html [ Failure ]

This import contains upstream changes from b778f69ee0d2a1080191d58f9d6eeb9c950b19d4 to 2e75f75414ccbc3ce82968cf05b04600fa28d254:
Move clip-path path reftest into wpt.: https://github.com/web-platform-tests/wpt/commit/2e75f75414ccbc3ce82968cf05b04600fa28d254 [affecting this directory]
Element::setAttribute() modified to accept TrustedTypes: https://github.com/web-platform-tests/wpt/commit/ef04d8b0f2e9a65ef82b33e03978ec0b34ec8c29
Return a 404 when trying to access a .any.* path that doesn't exist. (#12849): https://github.com/web-platform-tests/wpt/commit/cb4c37d196f1bf49f3c04b1ac077c392714b65ea
[css-properties-values-api] Reify values from styleMap.get.: https://github.com/web-platform-tests/wpt/commit/ba2287be3eb16c7c8b6f0ced3680a539309b2a14 [affecting this directory]

 
Status: Available (was: Untriaged)
Labels: Pri-3 Type-Bug
Labels: -Type-Bug Type-Feature
Summary: Support <path()> for 'clip-path' (was: [WPT] New failures introduced in external/wpt/css/css-masking by import https://crrev.com/c/1207214)
Both of these tests are for the path() function in clip-path, so "feature" in a sense. I think will mostly involve allowing the function during parsing, but there are potentially some gotchas w.r.t zooming.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31c2f3b540cae63fb9ebe9a58929eeefaf04dc6c

commit 31c2f3b540cae63fb9ebe9a58929eeefaf04dc6c
Author: Fredrik Söderquist <fs@opera.com>
Date: Thu Sep 06 10:14:00 2018

Update bug# for wpt/css/css-masking/clip-path/clip-path-path-00{1,2}.html

TBR=schenney@chromium.org

Bug: 880983
Change-Id: Ic31f977a104c95d1896ec4855c7be2c37e1e68d1
Reviewed-on: https://chromium-review.googlesource.com/1209342
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589127}
[modify] https://crrev.com/31c2f3b540cae63fb9ebe9a58929eeefaf04dc6c/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4574eb06b9b042dacf40b9221481b3bcbe92f2a5

commit 4574eb06b9b042dacf40b9221481b3bcbe92f2a5
Author: Fredrik Söderquist <fs@opera.com>
Date: Tue Sep 11 10:50:32 2018

Redirect WPT clip-path path() tests

TBR=schenney@chromium.org

Bug: 880983,  882649 
Change-Id: I5d75f448106ad20adf8e9e02ab33883b7eaa54a8
Reviewed-on: https://chromium-review.googlesource.com/1219247
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#590256}
[modify] https://crrev.com/4574eb06b9b042dacf40b9221481b3bcbe92f2a5/third_party/WebKit/LayoutTests/TestExpectations

 Issue 882649  has been merged into this issue.

Sign in to add a comment