New issue
Advanced search Search tips

Issue 880982 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

veyron_rialto-chrome-pfq BuildPackages failure 9/5

Project Member Reported by achuith@chromium.org, Sep 5

Issue description

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8936223124630227536

Not sure if this is transient since it has happened only once.

Logs aren't helpful:
ERROR   :  PGID  PPID   PID     ELAPSED     TIME %CPU COMMAND
ERROR   : Arguments of 10: ./build_packages '--board=veyron_rialto' '--accept_licenses=@CHROMEOS' '--withdebugsymbols' '--skip_chroot_upgrade' '--run_goma' '--withevents' '--eventfile=/mnt/host/source/buildbot_archive/veyron_rialto-chrome-pfq/R71-11037.0.0-rc1/build-events.json' 'virtual/target-os' 'virtual/target-os-dev' 'virtual/target-os-test' 'virtual/target-os-factory' 'virtual/target-os-factory-shim' 'chromeos-base/autotest-all'
ERROR   : Backtrace:  (most recent call is last)
ERROR   :  build_packages:313:main(), called: die_err_trap  
ERROR   : 
ERROR   : Command failed:
ERROR   :   Command 'MOD_PKGS=($(printf '%s
' "${MOD_PKGS[@]}" |       grep -v 'chromeos-base/chromeos-chrome'))' exited with nonzero code: 1
05:53:46: ERROR: 
 
Owner: vapier@chromium.org
Status: Started (was: WontFix)
i did get a report of this same failure mode from a dev

poking a bit, it looks like we can reproduce this if MOD_PKGS has only one item -- the one being grepped out.
  MOD_PKGS=( chromeos-base/chromeos-chrome )
  MOD_PKGS=($(printf '%s\n' "${MOD_PKGS[@]}" | grep -v 'chromeos-base/chromeos-chrome'))
  echo $?
  1

it's an uncommon scenario, but not one we should be failing on.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/5a11e87721f5b935c4f78926ab1c58197cc0093c

commit 5a11e87721f5b935c4f78926ab1c58197cc0093c
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Sep 08 01:37:09 2018

build_packages: ignore grep -v exit status

If `grep -v` filters out all lines, then it will exit 1.  In this case,
we don't care, as we wanted it to filter everything out.  Ignore grep's
exit status in these commands.
$ echo foo | grep -v foo; echo $?
1

BUG= chromium:880982 
TEST=precq passes

Change-Id: Ibfd34c3f8e7b06dacdd26bf1d694642ed6ba5dc5
Reviewed-on: https://chromium-review.googlesource.com/1208381
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Gregory Meinke <gmeinke@chromium.org>

[modify] https://crrev.com/5a11e87721f5b935c4f78926ab1c58197cc0093c/build_packages

Status: Fixed (was: Started)

Sign in to add a comment