New issue
Advanced search Search tips

Issue 880980 link

Starred by 1 user
Status: Fixed
Owner:
weidongg@chromium.org
Closed: Sep 7
Cc:
jen...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Hitting down key on last item in apps grid goes to the first zero state app

Project Member Reported by weidongg@chromium.org, Sep 5 
What steps will reproduce the problem?
(1) Enable zero state
(2) Hit down key when focus is on the last app

What is the expected result?
Focus should go to search box.

What happens instead?
Focus goes to the first zero state app.

Comment 1 by newcomer@chromium.org, Sep 6

Labels: -Pri-3 M-70 Pri-1
Owner: jen...@chromium.org

Comment 2 by weidongg@chromium.org, Sep 6

Cc: jen...@chromium.org
Owner: weidongg@chromium.org
Status: Assigned (was: Untriaged)
I can help investigate, since it is focus related.

Comment 3 by newcomer@chromium.org, Sep 6

Labels: M-70-Bug-Bash
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0d1db1e101f31c4290f9cee03083c125493bcac

commit d0d1db1e101f31c4290f9cee03083c125493bcac
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Sep 07 18:44:00 2018

Fix a focus issue for zero state

Changes:
Hide the search results page when search box is closed and reshow it
when search box is opened, so the focus will not move onto the suggested
apps in search results page when zero state is enabled.

Bug:  880980 
Change-Id: I6f32f0841fba094bc731bb0447f0f2cb055557b7
Reviewed-on: https://chromium-review.googlesource.com/1213926
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589604}
[modify] https://crrev.com/d0d1db1e101f31c4290f9cee03083c125493bcac/ash/app_list/views/app_list_main_view.cc
[modify] https://crrev.com/d0d1db1e101f31c4290f9cee03083c125493bcac/ash/app_list/views/contents_view.cc
[modify] https://crrev.com/d0d1db1e101f31c4290f9cee03083c125493bcac/ash/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/d0d1db1e101f31c4290f9cee03083c125493bcac/ash/app_list/views/search_result_page_view.h

Comment 5 by weidongg@chromium.org, Sep 7

Labels: Merge-Request-70
Status: Fixed (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 12 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 17 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 17

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5f20e5b225a6e9361e7ac876526698ce46fb65a

commit e5f20e5b225a6e9361e7ac876526698ce46fb65a
Author: Alex Newcomer <newcomer@chromium.org>
Date: Mon Sep 17 17:20:21 2018

Fix a focus issue for zero state

Changes:
Hide the search results page when search box is closed and reshow it
when search box is opened, so the focus will not move onto the suggested
apps in search results page when zero state is enabled.

TBR=weidongg@chromium.org

(cherry picked from commit d0d1db1e101f31c4290f9cee03083c125493bcac)

Bug:  880980 
Change-Id: I6f32f0841fba094bc731bb0447f0f2cb055557b7
Reviewed-on: https://chromium-review.googlesource.com/1213926
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589604}
Reviewed-on: https://chromium-review.googlesource.com/1228500
Cr-Commit-Position: refs/branch-heads/3538@{#448}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/e5f20e5b225a6e9361e7ac876526698ce46fb65a/ash/app_list/views/app_list_main_view.cc
[modify] https://crrev.com/e5f20e5b225a6e9361e7ac876526698ce46fb65a/ash/app_list/views/contents_view.cc
[modify] https://crrev.com/e5f20e5b225a6e9361e7ac876526698ce46fb65a/ash/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/e5f20e5b225a6e9361e7ac876526698ce46fb65a/ash/app_list/views/search_result_page_view.h
►

Sign in to add a comment