New issue
Advanced search Search tips

Issue 880979 link

Starred by 3 users
Status: Fixed
Owner:
jen...@chromium.org
Closed: Oct 4
Cc:
kaznacheev@chromium.org
weidongg@chromium.org
ginko@chromium.org
jen...@chromium.org
newcomer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Icon is blur and some are clipped in zero state

Project Member Reported by weidongg@chromium.org, Sep 5 
What steps will reproduce the problem?
(1) Enable #enable-zero-state-suggestions
(2) Click search box to activate zero state.

What is the expected result?
The icon shown is not blur and should not be clipped.

What happens instead?
The icon shown is blur and some are clipped.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by newcomer@chromium.org, Sep 6

Cc: weidongg@chromium.org kaznacheev@chromium.org
Labels: M-70
Owner: jen...@chromium.org
Screenshot? +kaznacheev for icon issue.

Comment 2 by newcomer@chromium.org, Sep 6

Labels: -Pri-3 Pri-1

Comment 3 by kaznacheev@chromium.org, Sep 6 

I am able to repro the blurry part, and I strongly suspect my recent change (https://chromium-review.googlesource.com/c/chromium/src/+/1195654). Looking into it.
Not seeing anything clipped though.

Comment 4 by kaznacheev@chromium.org, Sep 6 

Yep, that's the problem. Looking for a fix.

Comment 5 by kaznacheev@chromium.org, Sep 6 

Discussed with jennyz@, agreed that the best fix is introducing a new display type for zero state search results.

Comment 6 by newcomer@chromium.org, Sep 6

Labels: M-70-Bug-Bash

Comment 7 by jen...@chromium.org, Sep 6

Status: Started (was: Untriaged)

Comment 8 by jen...@chromium.org, Sep 10

Cc: newcomer@chromium.org ginko@chromium.org jen...@chromium.org
 Issue 882603  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2

commit d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2
Author: Jenny Zhang <jennyz@chromium.org>
Date: Fri Sep 21 19:58:05 2018

Fix the blurred app icon for suggestion chips without regression.

Since the recommendation app can be shown in both suggestion chip and zero state UI with different dimension, I added a chip_icon in SearchResultMeataData, so that we can load the icons in different dimension without resizing loss.

TBR=jianli@chromium.org

Bug:  880979 
Change-Id: Ibbea1d22eae7c15268bafb1fcca6c9211385b6ed
Reviewed-on: https://chromium-review.googlesource.com/1220813
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593309}
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/model/search/search_model.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/model/search/search_model.h
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/model/search/search_result.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/model/search/search_result.h
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/views/search_result_answer_card_view.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/views/search_result_list_view.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/views/search_result_suggestion_chip_view.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/views/search_result_tile_item_list_view.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/views/suggestion_chip_container_view.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/views/suggestion_chip_view.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/app_list/views/suggestions_container_view.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/public/cpp/app_list/app_list_config.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/public/cpp/app_list/app_list_config.h
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/ash/public/interfaces/app_list.mojom
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/extensions/chrome_app_icon_unittest.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/arc_app_result.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/arc_app_result.h
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/chrome_search_result.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/chrome_search_result.h
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/crostini_app_result.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/crostini_app_result.h
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/extension_app_result.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/extension_app_result.h
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/internal_app_result.cc
[modify] https://crrev.com/d38e9e8c4136a65bfc2f7b3361bc183dc2b65df2/chrome/browser/ui/app_list/search/search_controller_factory.cc

Comment 10 by kaznacheev@chromium.org, Sep 25

Labels: -M-70 M-71
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb85d45135af40b087a9cffb83d8c1108bbd85e1

commit cb85d45135af40b087a9cffb83d8c1108bbd85e1
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Fri Sep 28 17:28:38 2018

app_list: Fix crostini result icon size

CrostiniAppIconLoader should use the passed-in icon size
instead of from AppListConfig.

Bug:  880979 
Change-Id: I20840e4eced66ea2320149c57ebda4a9c8226341
Reviewed-on: https://chromium-review.googlesource.com/1251961
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595135}
[modify] https://crrev.com/cb85d45135af40b087a9cffb83d8c1108bbd85e1/chrome/browser/ui/app_list/crostini/crostini_app_icon_loader.cc

Comment 12 by jen...@chromium.org, Oct 4

Status: Fixed (was: Started)
►

Sign in to add a comment