New issue
Advanced search Search tips

Issue 880977 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Cannot drag an app to full page

Project Member Reported by weidongg@chromium.org, Sep 5

Issue description

What steps will reproduce the problem?
(1) Drag an app to a full page

What is the expected result?
The last app is pushed to next page.

What happens instead?
No gap is shown.


 
Cc: shibasheikh@chromium.org
Labels: -Pri-3 Pri-1
Labels: -M71 M-71
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f53253f8891ba2537d70a9b41054391c82ce0a5

commit 2f53253f8891ba2537d70a9b41054391c82ce0a5
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Sep 14 16:27:07 2018

Implement dragging to full page when apps grid gap is enabled

Changes:
1. During the dragging to full page, allow inserting placeholder and
   push the last item to next page via
   PagedViewStructure::ClearOverflow().
2. At the end of dragging, add a "page break" item behind the new last
   item and clear the "page break" item behind the old last item in
   local model and server.

Bug:  880977 
Test: AppsGridGapTest.MoveItemToPreviousFullPage

Change-Id: I318d46bb6917846e05f5552b040e45d8fe036319
Reviewed-on: https://chromium-review.googlesource.com/1220946
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591366}
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/ash/app_list/model/app_list_item_list.cc
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/ash/app_list/paged_view_structure.cc
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/ash/app_list/paged_view_structure.h
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/ash/app_list/test/test_app_list_client.h
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/ash/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/ash/app_list/views/apps_grid_view_unittest.cc
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/ash/public/interfaces/app_list.mojom
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/chrome/browser/ui/app_list/app_list_client_impl.cc
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/chrome/browser/ui/app_list/app_list_client_impl.h
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/chrome/browser/ui/app_list/app_list_model_updater.h
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/chrome/browser/ui/app_list/chrome_app_list_model_updater.cc
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/chrome/browser/ui/app_list/chrome_app_list_model_updater.h
[modify] https://crrev.com/2f53253f8891ba2537d70a9b41054391c82ce0a5/chrome/browser/ui/app_list/test/fake_app_list_model_updater.h

Status: Fixed (was: Assigned)
Issue 885267 has been merged into this issue.
Labels: Tablet-Polish

Sign in to add a comment