Folder comes along for the ride if you tap the pagination buttons (shopping carts) |
||||||||||||
Issue descriptionChrome Version: 70.0.3532.8 (Reproducable in M67) OS: Chrome What steps will reproduce the problem? (1) Open a folder (2) Tap a pagination button (3) Watch in horror as the folder remains open during the page transition What is the expected result? Folder closes, page switches What happens instead? Folder remains open and comes with you
,
Sep 6
Alex I don't know how to tag you. Anyway, I think Shiba wanted this in for M70, as part of my "number 3" bug to get done ASAP
,
Sep 7
Solved offline. If the solution isn't too complex we will merge it to M-70.
,
Sep 8
This seems to be a symptom of a larger problem where folder background view seems to get a separate copy of an event, and handling the event there doesn't prevent it from being handled below (specifically gesture events)
,
Sep 8
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b08f82e94d95541b28558895f3e740a3e7d8997a commit b08f82e94d95541b28558895f3e740a3e7d8997a Author: Kevin Strohbehn <ginko@google.com> Date: Wed Sep 12 17:59:49 2018 Folder Should no longer travel with users between pages Bug: 880975 Change-Id: I4a4a41833e4312c8a78ff6b74897e539bf456d1f Reviewed-on: https://chromium-review.googlesource.com/1220057 Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#590751} [modify] https://crrev.com/b08f82e94d95541b28558895f3e740a3e7d8997a/ash/app_list/views/folder_background_view.cc
,
Sep 12
,
Sep 12
,
Sep 13
Issue is more complex than previously thought, the fix I have in mind is far hackier than I'd like: it involves disabling pagination buttons while the folder is open. I'm hoping event-expert Oshima-san can shed some light on what's happening here!
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/335bfc3aa1ddbc6fc6289452523ca9e80f5ec9b0 commit 335bfc3aa1ddbc6fc6289452523ca9e80f5ec9b0 Author: Kevin Strohbehn <ginko@google.com> Date: Thu Sep 13 23:13:44 2018 Revert "Folder Should no longer travel with users between pages" This reverts commit b08f82e94d95541b28558895f3e740a3e7d8997a. Reason for revert: Causing issues with framerate and keyboard while folder is open Original change's description: > Folder Should no longer travel with users between pages > > Bug: 880975 > Change-Id: I4a4a41833e4312c8a78ff6b74897e539bf456d1f > Reviewed-on: https://chromium-review.googlesource.com/1220057 > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Commit-Queue: Kevin Strohbehn <ginko@google.com> > Cr-Commit-Position: refs/heads/master@{#590751} TBR=weidongg@chromium.org,ginko@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 880975 Change-Id: I107c456e6654b9808316314d5f53ded082041fc3 Reviewed-on: https://chromium-review.googlesource.com/1226197 Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#591199} [modify] https://crrev.com/335bfc3aa1ddbc6fc6289452523ca9e80f5ec9b0/ash/app_list/views/folder_background_view.cc
,
Sep 15
Too Complex to be worth tackling in the right way right now.
,
Sep 27
,
Oct 15
Bulk moving all M-71 <P-1's to M-72.
,
Oct 15
,
Nov 7
,
Nov 7
This actually wasn't as relevant as I thought it was
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 20
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by newcomer@chromium.org
, Sep 6