New issue
Advanced search Search tips

Issue 880959 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Sep 6
Cc:
omrilio@chromium.org
zork@chromium.org
minch@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Activate an unsnappable window should end both splitview and overview mode

Project Member Reported by x...@chromium.org, Sep 5 
Chrome Version: 71.0.3544.0
OS: Chrome

What steps will reproduce the problem?
(1) Enter tablet mode, open at least one snappable window and one unsnappable window
(2) Enter overview, snap the snappable window to left side of the screen
(3) Tap on the shelf icon of the unsnappable window to activate the window

What is the expected result?
The unsnappable window should get activated. Overview and splitview should both be ended

What happens instead?
Only splitview mode is ended. Overview mode is still active.

Comment 2 by x...@chromium.org, Sep 6

Status: Fixed (was: Assigned)

Comment 3 by x...@chromium.org, Sep 6

Labels: Merge-Request-70 M-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 7

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbda21bed5ef6e1322ff830626c67d7ce509fd39

commit dbda21bed5ef6e1322ff830626c67d7ce509fd39
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Fri Sep 07 17:00:44 2018

[Merge to 70]Activate an unsnappable window should end both splitview and overview.

TBR=xiyuan@chromium.org

Bug:  880959 
Change-Id: I87d4d222ea3b748171624846bfade66cca994a1b
Reviewed-on: https://chromium-review.googlesource.com/1208145
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589181}(cherry picked from commit b835d9c06e791f15255eb497ea88406874b3fd4f)
Reviewed-on: https://chromium-review.googlesource.com/1213379
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#144}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/dbda21bed5ef6e1322ff830626c67d7ce509fd39/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/dbda21bed5ef6e1322ff830626c67d7ce509fd39/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/dbda21bed5ef6e1322ff830626c67d7ce509fd39/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/dbda21bed5ef6e1322ff830626c67d7ce509fd39/ash/wm/splitview/split_view_controller_unittest.cc
►

Sign in to add a comment