New issue
Advanced search Search tips

Issue 880928 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox repeatedly reads title changes

Project Member Reported by dtseng@chromium.org, Sep 5

Issue description

- open a gmail tab
- send a chat to a google account

result:
ChromeVox repeatedly speaks title changes

expected:
no chattiness

 
Labels: -Pri-3 M-70 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b73e799917801b72f613b7220652dd37e8f92877

commit b73e799917801b72f613b7220652dd37e8f92877
Author: David Tseng <dtseng@chromium.org>
Date: Wed Sep 05 22:44:24 2018

Partial revert of title changed event listener in ChromeVox

Bug:  880928 
Change-Id: I373480d1431ba07e2f60332d429052d364f04ce2
Reviewed-on: https://chromium-review.googlesource.com/1207098
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589036}
[modify] https://crrev.com/b73e799917801b72f613b7220652dd37e8f92877/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/b73e799917801b72f613b7220652dd37e8f92877/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Labels: Merge-Request-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 6

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c24a35a035eba4fd0189c6804f89b7f8449016d

commit 1c24a35a035eba4fd0189c6804f89b7f8449016d
Author: David Tseng <dtseng@chromium.org>
Date: Mon Sep 10 16:20:41 2018

Merge to m70: Partial revert of title changed event listener in ChromeVox

(cherry picked from commit b73e799917801b72f613b7220652dd37e8f92877)

Bug:  880928 
Change-Id: I373480d1431ba07e2f60332d429052d364f04ce2
Reviewed-on: https://chromium-review.googlesource.com/1207098
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589036}
Reviewed-on: https://chromium-review.googlesource.com/1216708
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#220}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/1c24a35a035eba4fd0189c6804f89b7f8449016d/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/1c24a35a035eba4fd0189c6804f89b7f8449016d/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Status: Fixed (was: Started)

Sign in to add a comment