New issue
Advanced search Search tips

Issue 880920 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Older pdf is rendered in browser as blank pages, page count is correct

Reported by schiresw...@gmail.com, Sep 5

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Steps to reproduce the problem:
1. Open pdf in browser
2. 
3. 

What is the expected behavior?
See the text and drawings

What went wrong?
All pages are blank. Can't attach full pdf due to privacy concerns. Attaching a "spacer" page from the full verison, this should have a black stripe at the top right.

Did this work before? N/A 

Chrome version: 69.0.3497.81  Channel: stable
OS Version: 10.0
Flash Version:
 
DOC 54.pdf
9.5 KB Download
This issue seems very similar to issue 774030.
Components: Internals>Plugins>PDF
Status: Available (was: Unconfirmed)
Labels: OS-Chrome OS-Linux OS-Mac
It does look like the same thing, but hard to confirm without actually trying to fix it.
Labels: -Type-Bug Type-Bug-Regression
Owner: thestig@chromium.org
Status: Assigned (was: Available)
Regressed in this range: https://chromium.googlesource.com/chromium/src/+log/53d030a1..07a8b562 -> r554557 -> https://pdfium-review.googlesource.com/31538

http://library.sciencemadness.org/library/books/gergel_isopropyl_bromide.pdf is another example broken in the same way.
Issue 882694 has been merged into this issue.
Bug reporter: Did you scan a document to generate the PDF that included the "DOC 54.pdf" sample? If yes, can we get permission to include your sample in our public PDF repository, which we use for testing?
Labels: Target-70 Target-71 RegressedIn-68 FoundIn-71 FoundIn-70 FoundIn-68 FoundIn-69
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/7a45d5722c7e75bfd9c53b0a2ba1e42a2fcc9626

commit 7a45d5722c7e75bfd9c53b0a2ba1e42a2fcc9626
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Sep 11 16:39:59 2018

Fix a regression in CJBig2_Context::HuffmanAssignCode().

An assignment statement accidentally got removed in
https://pdfium-review.googlesource.com/c/pdfium/+/31538.

BUG= chromium:880920 

Change-Id: Iaff20bd2484cd8bf6dc6a13cbf444cefbd605b25
Reviewed-on: https://pdfium-review.googlesource.com/42250
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/7a45d5722c7e75bfd9c53b0a2ba1e42a2fcc9626/core/fxcodec/jbig2/JBig2_Context.cpp

Status: Fixed (was: Started)
This is fixed in PDFium. The fix should make it into Chrome Canary by tomorrow. Once we verify the fix, we will try for a M70 merge.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba8d57838f039b37582a07d4d46ac1c9e62cd796

commit ba8d57838f039b37582a07d4d46ac1c9e62cd796
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Sep 11 18:31:35 2018

Roll src/third_party/pdfium 9039169b64e1..7a45d5722c7e (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/9039169b64e1..7a45d5722c7e


git log 9039169b64e1..7a45d5722c7e --date=short --no-merges --format='%ad %ae %s'
2018-09-11 thestig@chromium.org Fix a regression in CJBig2_Context::HuffmanAssignCode().


Created with:
  gclient setdep -r src/third_party/pdfium@7a45d5722c7e

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:880920 
TBR=dsinclair@chromium.org

Change-Id: Iafb1581dad97b0064927dad48286a12dbe526e57
Reviewed-on: https://chromium-review.googlesource.com/1220228
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590414}
[modify] https://crrev.com/ba8d57838f039b37582a07d4d46ac1c9e62cd796/DEPS

My test case renders correctly in Canary 71.0.3550.0

Labels: Merge-Request-70
You have permission to add DOC 54.pdf to your repository. Sorry for the delay.
Thanks for the test PDF. No rush.
Project Member

Comment 16 by sheriffbot@chromium.org, Sep 12

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/01c91e48b2838957adaf675bdde20d860217c7ff

commit 01c91e48b2838957adaf675bdde20d860217c7ff
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Sep 12 21:44:12 2018

Roll testing/corpus/ e1005e0e7..6cd71979b (1 commit)

https://pdfium.googlesource.com/pdfium_tests/+log/e1005e0e7857..6cd71979b56e

$ git log e1005e0e7..6cd71979b --date=short --no-merges --format='%ad %ae %s'
2018-09-12 thestig Add more test PDFs to the corpus.

Created with:
  roll-dep testing/corpus

TBR=hnakashima@chromium.org
BUG= chromium:880920 ,chromium:883026

Change-Id: I9298f3da42b6682c1aab7f0d43cc3a1e2d935573
Reviewed-on: https://pdfium-review.googlesource.com/42354
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/01c91e48b2838957adaf675bdde20d860217c7ff/DEPS

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cae0209f6aa85d1f229f47bec639d388639ae7b0

commit cae0209f6aa85d1f229f47bec639d388639ae7b0
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Sep 12 23:22:44 2018

Roll src/third_party/pdfium 987416db2271..01c91e48b283 (2 commits)

https://pdfium.googlesource.com/pdfium.git/+log/987416db2271..01c91e48b283


git log 987416db2271..01c91e48b283 --date=short --no-merges --format='%ad %ae %s'
2018-09-12 thestig@chromium.org Roll testing/corpus/ e1005e0e7..6cd71979b (1 commit)
2018-09-12 rharrison@chromium.org Optimize CPDF_CMapParser


Created with:
  gclient setdep -r src/third_party/pdfium@01c91e48b283

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:880920 ,chromium:883026, chromium:881678 
TBR=dsinclair@chromium.org

Change-Id: I568df1014f4041ca53ea2aa93ef6837afd0b5329
Reviewed-on: https://chromium-review.googlesource.com/1222707
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590855}
[modify] https://crrev.com/cae0209f6aa85d1f229f47bec639d388639ae7b0/DEPS

Specifically what needs to be merged?
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/6d12d80ae363f47e14cbb830757f91f7c8513dab

commit 6d12d80ae363f47e14cbb830757f91f7c8513dab
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Sep 18 17:04:37 2018

M70: Fix a regression in CJBig2_Context::HuffmanAssignCode().

An assignment statement accidentally got removed in
https://pdfium-review.googlesource.com/c/pdfium/+/31538.

BUG= chromium:880920 

Change-Id: Iaff20bd2484cd8bf6dc6a13cbf444cefbd605b25
Reviewed-on: https://pdfium-review.googlesource.com/42250
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
(cherry picked from commit 7a45d5722c7e75bfd9c53b0a2ba1e42a2fcc9626)
Reviewed-on: https://pdfium-review.googlesource.com/42710
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/6d12d80ae363f47e14cbb830757f91f7c8513dab/core/fxcodec/jbig2/JBig2_Context.cpp

Thanks everyone. We are all set for M70.

Sign in to add a comment