New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 880915: Add more test targets to the "Mojo Android" FYI bot

Reported by timvolod...@chromium.org, Sep 5 Project Member

Issue description

Currently the "Mojo Android" FYI bots mainly runs the following two test targets:
- network_service_content_browsertests
- viz_content_browsertests

To ensure more test coverage on Android while migrating to the NetworkService, we may want to add the following targets.

As on marshamallow-arm64-rel bot [1]:
- components_browsertests
- components_unittests
- content_browsertests
- content_shell_test_apk
- net_unittests

As on e.g. Oreo Phone Tester [2]:
- chrome_public_test_apk


[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-marshmallow-arm64-rel

[2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester
 

Comment 1 by timvolod...@chromium.org, Sep 5

Cc: cduvall@chromium.org jam@chromium.org
+jam@ and cduvall@: to confirm this is indeed something we may want..

Comment 2 by jam@chromium.org, Sep 5

Thanks Tim.

I think we also want webview_instrumentation_test_apk per your suggestion yesterday?

No need to run net_unittests and components_unittests; the network service specific codepaths only matter in integration tests.

No need to run network_service_content_browsertests on it; we should just run content_browsertests and all targets on that bot would have network service enabled.

Comment 3 by cduvall@chromium.org, Sep 5

Looks like we also have a webview specific mojo bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-mojo-webview-rel

Do we only want the webview_instrumentation_test_apk on that one?

Comment 4 by jam@chromium.org, Sep 5

ah sure that sg

Comment 5 by dtrainor@chromium.org, Sep 5

Components: Test>Android
Adding a component as part of the initial Chrome Android triage.  Let me know if this isn't the right one.

Comment 6 by cduvall@chromium.org, Sep 5

Owner: cduvall@chromium.org
Status: Started (was: Untriaged)

Comment 7 by timvolod...@chromium.org, Sep 5

yes we definitely want webview_instrumentation_test_apk to run on the android webview bot. I filed a separate bug for this crbug.com/861740. Looks like the android_webview_unittests target is generally passing and hence probably not really interesting to add there..

Comment 8 by timvolod...@chromium.org, Sep 5

also looking at a trybot run with Network Service enabled [1] it seems like some components_unittests are filing and so might still be interesting to include that as well..

[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/78789

Comment 9 by cduvall@chromium.org, Sep 5

The unittests are also failing on desktop (the desktop mojo bots don't run them), so not sure if we want to worry about those for android.

Comment 10 by bugdroid1@chromium.org, Sep 10

Project Member

Comment 11 by cduvall@chromium.org, Sep 10

Status: Fixed (was: Started)

Comment 12 by bugdroid1@chromium.org, Sep 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b895e8ed2f617ad83d9517b5442a9dc1b59fc5ef

commit b895e8ed2f617ad83d9517b5442a9dc1b59fc5ef
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Sep 11 18:09:13 2018

Remove viz tests from Android mojo bots

These were removed from all other Android bots in
http://crrev.com/c/1199682.

Bug:  880915 
Change-Id: I3da3ddd2651b889bb440e691ef14b2e54e055475
Reviewed-on: https://chromium-review.googlesource.com/1219968
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590403}
[modify] https://crrev.com/b895e8ed2f617ad83d9517b5442a9dc1b59fc5ef/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/b895e8ed2f617ad83d9517b5442a9dc1b59fc5ef/testing/buildbot/test_suites.pyl

Comment 13 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10692b98cca291e29f79fe8df9aae71b1ac452ff

commit 10692b98cca291e29f79fe8df9aae71b1ac452ff
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Dec 07 00:59:23 2018

Support using gtest_filter and test-launcher-filter-file together on Android

These args used to be mutually exclusive, which would cause errors when
retrying the Android network service tests (which use
--test-launcher-filter-file). This combines the filters specified in the
filter file with the gtest_filter argument.

See here for an example of a failure:
https://chromium-swarm.appspot.com/task?id=41984d0ac388e010

Bug:  880915 
Change-Id: I2fee107d13c44bd90cd9532bcabda4bb12f7e111
Reviewed-on: https://chromium-review.googlesource.com/c/1364071
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614509}
[modify] https://crrev.com/10692b98cca291e29f79fe8df9aae71b1ac452ff/build/android/pylib/utils/test_filter.py
[modify] https://crrev.com/10692b98cca291e29f79fe8df9aae71b1ac452ff/build/android/pylib/utils/test_filter_test.py

Sign in to add a comment