New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Closed: Sep 10
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Sign in to add a comment

Issue 880915: Add more test targets to the "Mojo Android" FYI bot

Reported by, Sep 5 Project Member

Issue description

Currently the "Mojo Android" FYI bots mainly runs the following two test targets:
- network_service_content_browsertests
- viz_content_browsertests

To ensure more test coverage on Android while migrating to the NetworkService, we may want to add the following targets.

As on marshamallow-arm64-rel bot [1]:
- components_browsertests
- components_unittests
- content_browsertests
- content_shell_test_apk
- net_unittests

As on e.g. Oreo Phone Tester [2]:
- chrome_public_test_apk



Comment 1 by, Sep 5

+jam@ and cduvall@: to confirm this is indeed something we may want..

Comment 2 by, Sep 5

Thanks Tim.

I think we also want webview_instrumentation_test_apk per your suggestion yesterday?

No need to run net_unittests and components_unittests; the network service specific codepaths only matter in integration tests.

No need to run network_service_content_browsertests on it; we should just run content_browsertests and all targets on that bot would have network service enabled.

Comment 3 by, Sep 5

Looks like we also have a webview specific mojo bot:

Do we only want the webview_instrumentation_test_apk on that one?

Comment 4 by, Sep 5

ah sure that sg

Comment 5 by, Sep 5

Components: Test>Android
Adding a component as part of the initial Chrome Android triage.  Let me know if this isn't the right one.

Comment 6 by, Sep 5

Status: Started (was: Untriaged)

Comment 7 by, Sep 5

yes we definitely want webview_instrumentation_test_apk to run on the android webview bot. I filed a separate bug for this Looks like the android_webview_unittests target is generally passing and hence probably not really interesting to add there..

Comment 8 by, Sep 5

also looking at a trybot run with Network Service enabled [1] it seems like some components_unittests are filing and so might still be interesting to include that as well..


Comment 9 by, Sep 5

The unittests are also failing on desktop (the desktop mojo bots don't run them), so not sure if we want to worry about those for android.

Comment 10 by, Sep 10

Project Member

Comment 11 by, Sep 10

Status: Fixed (was: Started)

Comment 12 by, Sep 11

Project Member
The following revision refers to this bug:

commit b895e8ed2f617ad83d9517b5442a9dc1b59fc5ef
Author: Clark DuVall <>
Date: Tue Sep 11 18:09:13 2018

Remove viz tests from Android mojo bots

These were removed from all other Android bots in

Bug:  880915 
Change-Id: I3da3ddd2651b889bb440e691ef14b2e54e055475
Reviewed-by: John Budorick <>
Commit-Queue: Clark DuVall <>
Cr-Commit-Position: refs/heads/master@{#590403}

Comment 13 by, Dec 7

Project Member
The following revision refers to this bug:

commit 10692b98cca291e29f79fe8df9aae71b1ac452ff
Author: Clark DuVall <>
Date: Fri Dec 07 00:59:23 2018

Support using gtest_filter and test-launcher-filter-file together on Android

These args used to be mutually exclusive, which would cause errors when
retrying the Android network service tests (which use
--test-launcher-filter-file). This combines the filters specified in the
filter file with the gtest_filter argument.

See here for an example of a failure:

Bug:  880915 
Change-Id: I2fee107d13c44bd90cd9532bcabda4bb12f7e111
Commit-Queue: Clark DuVall <>
Reviewed-by: John Budorick <>
Cr-Commit-Position: refs/heads/master@{#614509}

Sign in to add a comment