New issue
Advanced search Search tips

Issue 880880 link

Starred by 9 users

Issue metadata

Status: Duplicate
Merged: issue 811921
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Select "Dvorak - QWERTY ⌘" Keyboard Shortcuts Broken

Reported by crdnil...@gmail.com, Sep 5

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Steps to reproduce the problem:
1. Change your keyboard layout to "Dvorak - QWERTY ⌘", a layout that will switch back to QWERTY when holding the ⌘ key.
2. Press Shift Cmd T (reopen closed tab) or Shift Cmd N (incognito window). 

What is the expected behavior?
Shift Cmd T reopens the last closed tab.
Shift Cmd N opens an incognito window.

What went wrong?
Shift Cmd T incorrectly opens a new tab
Shift Cmd N incorrectly opens a normal window

Did this work before? N/A 

Chrome version: 69.0.3497.81  Channel: stable
OS Version: OS X 10.13.6
Flash Version: 

It seems to be Shift + Cmd shortcuts, all my other shortcuts work as expected.
 
Cc: erikc...@chromium.org
Components: -UI UI>Input>KeyboardShortcuts
Confirmed for me too. I’m a user of Canary and noticed the issue about a month ago. Don’t remember the exact version. But now it’s present in Chrome stable v69

Comment 3 Deleted

Labels: Needs-Triage-M69
Labels: Needs-TestConfirmation
Cc: -erikc...@chromium.org
Labels: -Type-Bug -Pri-2 -Needs-TestConfirmation hasbisect-per-revision ReleaseBlock-Stable Triaged-ET M-69 RegressedIn-69 FoundIn-70 Target-69 FoundIn-69 Pri-1 Type-Bug-Regression
Owner: erikc...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported version 69.0.3497.81 and the same is not seen on latest canary# 71.0.3543.0 and Dev# 70.0.3534.4 using Mac 10.13.6, hence providing reverse bisect info
Note: Issue is specific to Mac

Reverse Bisect Info:
================
Last Bad build: 70.0.3517.0
First Good build: 70.0.3518.0

You are probably looking for a change made after 581751 (known good), but no later than 581752 (first known bad).
https://chromium.googlesource.com/chromium/src/+log/76b1e8939a13e7a1687abc20e8502a7ca806d2ed..008ab23a1b001dedc34c213ed56d42d5a7868838
Change-Id: I7fe79bc9ba860dc018e8fbfed9836e27fca17f85
Reviewed-on: https://chromium-review.googlesource.com/1167466

@erikchen: Please confirm the issue and help in re-assigning if it is not related to your change, help in merging it to M-69 if applicable
Adding ReleaseBlock-Stable for M-69, feel free to remove it if not applicable.

Thanks!
Labels: -FoundIn-70
Cc: thakis@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable -M-69 -Target-69 Target-71 M-71 Pri-2
Let's target a fix for this at M71. This is not RBS and certainly not RBS for M69.
Status: Fixed (was: Assigned)
Agreed. This is fixed on Canary by https://chromium-review.googlesource.com/c/chromium/src/+/1167466. 

"""
git find-releases 008ab23a1b001dedc34c213ed56d42d5a7868838
commit 008ab23a1b001dedc34c213ed56d42d5a7868838 was:
  initially in branch-heads/3518~279 [untagged]
No merges found. If this seems wrong, be sure that you did:
  git fetch origin && gclient sync --with_branch_heads
"""

Which landed at release 3518. The latest dev is at 70.0.3534.4, so there's nothing to do here. This will be fixed in M-70.
Mergedinto: 811921
Status: Duplicate (was: Fixed)
Issue 880564 has been merged into this issue.
Cc: viswa.karala@chromium.org
 Issue 881569  has been merged into this issue.
Cc: susan.boorgula@chromium.org
 Issue 881233  has been merged into this issue.
 Issue 883961  has been merged into this issue.
Cc: erikc...@chromium.org
 Issue 892196  has been merged into this issue.
@erikchen using v70 now and the main issue is fixed, however ctrl+shift+tab acts as control+tab. That is, control+shift+tab advances through the tabs in the forwards direction.

I tried it in a regular QWERTY keyboard, and it works fine. So it seems this issue is limited to Dvorak - Qwerty Command.
it only seems to be control+shift+tab though, command+shift+[ still goes backwards.
See  issue 896389  for control+shift+tab on Dvorak-Qwerty

Sign in to add a comment