[VR Browsing] Hover with reticle is broken |
||||||||||||
Issue descriptionChrome Version: 71.0.3542.0 and 70.0.3538.7 OS: O Device: Pixel 2XL, (Standalone, etc. (Should be all devices) Note: Doesn't occur on M69 69.0.3497.76 What steps will reproduce the problem? (1) Go to any Youtube video (2) Enter VR Browsing and fullscreen the video (not required, but makes the issue stand out) (3) Let the video controls auto hide, then hover the reticle over the video. What is the expected result? Video controls should appear when the reticle hovers on the video. What happens instead? The video controls don't appear. They now require a click action to appear. This pertains to all hover in VR browsing. Links in Wikipedia for example should highlight on hover, but they don't.
,
Sep 7
Verified in Canary
,
Sep 8
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b47e1342c67e0980c6206449a009897ef3ec3d1 commit 7b47e1342c67e0980c6206449a009897ef3ec3d1 Author: Aldo Culquicondor <acondor@chromium.org> Date: Mon Sep 10 14:56:30 2018 Add source to hover events for VR Hover events don't get processed if the source is not set. This change shouldn't affect scrolling performance metrics. Bug: 880879 , 877580 Change-Id: I07ae28fcfdebfee77eab57e5659d1150745b6e9a Reviewed-on: https://chromium-review.googlesource.com/1207651 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589151}(cherry picked from commit 6429116387660e52bed97d4eb7470665f999dd95) Reviewed-on: https://chromium-review.googlesource.com/1216522 Reviewed-by: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#214} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/7b47e1342c67e0980c6206449a009897ef3ec3d1/content/public/android/java/src/org/chromium/content/browser/MotionEventSynthesizerImpl.java
,
Sep 10
,
Sep 10
,
Sep 10
Thanks for adding the Test-Manual label Aldo, pointing out that there should be specific test coverage for this. So I updated one of our tests "Media controls hide on idle" to "Media controls hide on idle, and appear on hover." do just that. Additionally, our media controls functionality testing caught this, and is another layer for it. @vsupruniuk@google.com - could you verify this once M70+this fix hits beta? And then re-assign it to Aldo once you're done please, thanks.
,
Sep 10
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 6