Extensions Click-to-Script: Refresh page bubble shouldn't show over the wrench menu |
||||||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1) Enable chrome://flags/#extension-active-script-permission (2) Install an extension that needs to run at document_start or uses webRequest (3) Put the extension in the overflow menu (4) Visit a site the extension wants to run on and click on the extension in the overflow menu What is the expected result? Minimum: Wrench menu should close and then the bubble should show. Possibly Better: Close the wrench menu and pop out the extension, then anchor the bubble to the extension (like we do for browser action popups). This might be messier. What happens instead? The bubble opens over the wrench menu, and can't actually be interacted with. bklmn@, any preference between the two possible "fix" behaviors? karandeepb@, would you be able to look into this? (For now, we could probably start with the "Close the menu" approach.) Note: only tested on Mac so far, but likely affects all platforms.
,
Sep 6
I am not sure why this is RVG?
,
Sep 6
I think the cts bug template defaults to RVG (which is probably reasonable). But yeah, no reason for this one to be. Removing.
,
Sep 6
,
Sep 6
On non-Mac platforms, this closes the wrench menu and then shows the bubble. On Mac, the behavior is as described in the report. Elly: Can you have someone take a look? We'll probably need to merge a fix for this in M70. I can implement a generic fix but I think this might be some MacViews bug.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4f92dd3fbf3a95f1761fa3d2b03dce6d6f06933 commit c4f92dd3fbf3a95f1761fa3d2b03dce6d6f06933 Author: Karan Bhatia <karandeepb@chromium.org> Date: Tue Sep 11 19:17:28 2018 CTS: Close app menu before showing blocked action bubble when needed. Currently on Mac, when the blocked action bubble is shown for an extension in the app menu, it is shown over the app menu and it's not possible to interact with the bubble. Fix this by closing the app menu if needed before showing the bubble. Tested with both Cocoa and Views browser windows. BUG= 880875 Change-Id: I3ab9b1136f01ca1cf5dd13fd51831f05072c8437 Reviewed-on: https://chromium-review.googlesource.com/1211964 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590433} [modify] https://crrev.com/c4f92dd3fbf3a95f1761fa3d2b03dce6d6f06933/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/c4f92dd3fbf3a95f1761fa3d2b03dce6d6f06933/chrome/browser/ui/toolbar/toolbar_actions_bar.cc [modify] https://crrev.com/c4f92dd3fbf3a95f1761fa3d2b03dce6d6f06933/chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h [modify] https://crrev.com/c4f92dd3fbf3a95f1761fa3d2b03dce6d6f06933/chrome/browser/ui/views/toolbar/browser_actions_container.cc [modify] https://crrev.com/c4f92dd3fbf3a95f1761fa3d2b03dce6d6f06933/chrome/browser/ui/views/toolbar/browser_actions_container.h
,
Sep 11
,
Sep 12
karandeepb@ - Could you please provide a sample extension file to verify the issue from TE-end. Thanks...!!
,
Sep 12
Try with an extension from the chrome web store, e.g, https://chrome.google.com/webstore/detail/adblock/gighmmpiobklfepjocnamgkkbiglidom?hl=en-US.
,
Sep 14
,
Sep 14
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 17
Unable to reproduce the issue on mac 10.13.3 using build without fix as per comment #0 and #9. Observed that wrench menu closed and then the bubble showed on the extension. Note: Observed same behaviour using build with fix i.e chrome version #71.0.3554.0. karandeepb@ - Could you please check the attached screen casts of build without fix and build with fix and please help us in confirming the fix. Thanks...!!
,
Sep 17
c#12: The extension should be in wants-to-run state in the context menu, when you click on it. So you should first right click the extension. Go to Allow Extension -> On click. (or This can read and change site Data -> When you click on the extension). Then refresh the page. The extension should go to the wants-to-run state (be highlighted with a with circle on it). Now click on the extension in the wrench menu which should launch a bubble over the menu.
,
Sep 18
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix. Verified the fix on Mac 10.13.3 using Chrome version #71.0.3555.0 as per the comment #0 and #12. Attaching screen cast for reference. Observed that wrench menu closed and then the bubble was shown. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Sep 18
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a76ef81ff07b0ed5147a8b26897bfca6be143012 commit a76ef81ff07b0ed5147a8b26897bfca6be143012 Author: Karan Bhatia <karandeepb@chromium.org> Date: Tue Sep 18 21:37:32 2018 [Merge M70] CTS: Close app menu before showing blocked action bubble when needed. Currently on Mac, when the blocked action bubble is shown for an extension in the app menu, it is shown over the app menu and it's not possible to interact with the bubble. Fix this by closing the app menu if needed before showing the bubble. Tested with both Cocoa and Views browser windows. TBR=rdevlin.cronin@chromium.org BUG= 880875 Change-Id: I3ab9b1136f01ca1cf5dd13fd51831f05072c8437 Reviewed-on: https://chromium-review.googlesource.com/1211964 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590433}(cherry picked from commit c4f92dd3fbf3a95f1761fa3d2b03dce6d6f06933) Reviewed-on: https://chromium-review.googlesource.com/1232199 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#508} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/a76ef81ff07b0ed5147a8b26897bfca6be143012/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/a76ef81ff07b0ed5147a8b26897bfca6be143012/chrome/browser/ui/toolbar/toolbar_actions_bar.cc [modify] https://crrev.com/a76ef81ff07b0ed5147a8b26897bfca6be143012/chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h [modify] https://crrev.com/a76ef81ff07b0ed5147a8b26897bfca6be143012/chrome/browser/ui/views/toolbar/browser_actions_container.cc [modify] https://crrev.com/a76ef81ff07b0ed5147a8b26897bfca6be143012/chrome/browser/ui/views/toolbar/browser_actions_container.h
,
Sep 26
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix. Verified the fix on Mac 10.13.3 using Chrome version #70.0.3538.35 as per the comment #0 and #13. Attaching screen cast for reference. Observed that wrench menu closed and then the bubble was shown. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by karandeepb@chromium.org
, Sep 6