I believe this change is inconsistent with other developer-focused hotkeys: ⌘+⌥ + i, ⌘+⌥ + j, ⌘+⌥ + u and should be reverted.

For the record, ⌘+⇧ + i opens Apple Mail while ⌘+⇧ + j opens the downloads tab.

Able to reproduce the issue on mac 10.13.3 using chrome reported version #69.0.3497.81 and latest canary #71.0.3543.0. Issue is specific to OS-mac.

Bisect Information:
=====================
Good build: 69.0.3451.0
Bad Build : 69.0.3455.0
Note: The intermediate builds are not available for OS-mac.

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/d336237114fa729aad6d538a532b6d0b5faa4cc2..315d4286bf50511d859f1c4f205966f4bccc5c22

From the above change log suspecting below change
Change-Id: Ic74e418bd9fa55eda90dd3bd55b10a456abce581
Reviewed-on: https://chromium-review.googlesource.com/1093301

erikchen@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding stable blocker for M-69 as it seems to be a recent regression. Please feel free to remove the same if not appropriate.

Thanks...!!

When the shortcut was added 8 years ago, it was always intended to be cmd + shift + c:
http://codereview.chromium.org/3011002

The fact that it triggered off of anything different was a bug in Chrome that was fixed.

Not sure who should own this -- over to pfeldman to find an OWNER in devtools. Maybe should chat with the UX team? +ellyjones has Mac TL.

Given that the shortcut worked for 8 years, it might be deep in the muscle memory of the devtools users, so we should claim it. We should probably revert this with the first security update that we have.

Hi pfeldman,
Please clarify: Are you suggesting that both:

<cmd + shift + c> and <cmd + option + c> should trigger devtools panel, or only the latter? 

Also, can you clarify why this should go out with a security update? It's not clear to me that this is significant enough to warrant a merge to stable [or even beta].

The keyboard shortcut is also not present in the macOS main menu, which is the canonical place for these shortcuts to go on macOS. Note that the shortcut is not discoverable for new developers.

Deleted: Screen Shot 2018-09-06 at 3.44.00 PM.png 42.5 KB

	Screen Shot 2018-09-06 at 3.44.00 PM.png 42.5 KB View Download

Reports of this on Twitter:

https://twitter.com/jBleuzen/status/1037605328190431232

https://twitter.com/jeffwesson/status/1037432288865181696

>> <cmd + shift + c> and <cmd + option + c> should trigger devtools panel, or only the latter? 

I'd say bring it to the way it was so that it was not perceived as a regression.

>> Also, can you clarify why this should go out with a security update? It's not clear to me that this is significant enough to warrant a merge to stable [or even beta].

You regressed an entry point into the large feature set, so I'd say it should be fixed. We don't have UMA for that exact shortcut, so it is hard to say how many users are affected. There are tweets, so it is visible.

>> The keyboard shortcut is also not present in the macOS main menu, which is the canonical place for these shortcuts to go on macOS. Note that the shortcut is not discoverable for new developers.

We have Cmd+Shift+I, Cmd+Shift+J, and Cmd+Opt+C. Sounds like people aligned that last one with the first pair, so there is enough discoverability.

The shortcut is documented in the devtools docs and this change definitely breaks convention from the other shortcuts.

Deleted: ss-2018-09-06-15-54-30.png 39.0 KB

	ss-2018-09-06-15-54-30.png 39.0 KB View Download

Spoke with pfeldman@ offline.

This will not block the stable rollout. We'll do our best to get a fix merged to M69 [a revert of the CL in question is not viable as that CL in turn fixes other issues]. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ee15a5089815f2c83ce7795ef5676b3ef071b85

commit 7ee15a5089815f2c83ce7795ef5676b3ef071b85
Author: erikchen <erikchen@chromium.org>
Date: Thu Sep 06 22:06:29 2018

Add another shortcut for inspect element keyboard shortcut.

The inspect element keyboard shortcut when it was added 8 years ago was
intended to be command + shift + c. Due to a bug in the implementation, it
triggered off of both <cmd + shift +c> and <cmd + option + c>.

See https://codereview.chromium.org/3011002.

Recent refactors fixed the logic so that it correctly triggered off of only <cmd
+ shift + c>. Since some users have gotten used to <cmd + option + c>, this CL
manually adds that also as a hidden shortcut for devtools.

Bug:  880867 
Change-Id: Idb70ee26afa485874674171642b8d380b50528ad
Reviewed-on: https://chromium-review.googlesource.com/1211504
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589328}
[modify] https://crrev.com/7ee15a5089815f2c83ce7795ef5676b3ef071b85/chrome/browser/global_keyboard_shortcuts_mac.mm

Pls update bug with canary result tomorrow. Thank you.

 Issue 881221  has been merged into this issue.

Able to reproduce the issue on Mac 10.13.3 using chrome reported version #69.0.3497.81

Verified the fix on Mac 10.13.3 using latest chrome version #71.0.3545.0 as per the comment #0.
Attaching screen cast for reference.
Observed that devtools window opened with the elements panel as the active panel using ⌘+⌥ + c (command + option + c).
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!

Deleted: 880867.mp4 904 KB

	880867.mp4 904 KB View Download

The NextAction date has arrived: 2018-09-07

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This merge is quite safe [1 line addition to an array]. 

I would deem this medium priority -- if there's another stable spin, it would be good to get the fix in.

Approving merge to M69 branch 3497 based on comment #16, #20 and per offline chat with erikchen@. Please merge ASAP, thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062ca7529217458b3506062ef751020bf7e55c65

commit 062ca7529217458b3506062ef751020bf7e55c65
Author: erikchen <erikchen@chromium.org>
Date: Fri Sep 07 14:41:02 2018

[Merge to 3497] Add another shortcut for inspect element keyboard shortcut.

The inspect element keyboard shortcut when it was added 8 years ago was
intended to be command + shift + c. Due to a bug in the implementation, it
triggered off of both <cmd + shift +c> and <cmd + option + c>.

See https://codereview.chromium.org/3011002.

Recent refactors fixed the logic so that it correctly triggered off of only <cmd
+ shift + c>. Since some users have gotten used to <cmd + option + c>, this CL
manually adds that also as a hidden shortcut for devtools.

Bug:  880867 
Change-Id: Idb70ee26afa485874674171642b8d380b50528ad
Reviewed-on: https://chromium-review.googlesource.com/1211504
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589328}(cherry picked from commit 7ee15a5089815f2c83ce7795ef5676b3ef071b85)
Reviewed-on: https://chromium-review.googlesource.com/1213504
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#901}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/062ca7529217458b3506062ef751020bf7e55c65/chrome/browser/global_keyboard_shortcuts_mac.mm

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision de3adf1bc0032ea5d195dfb80ebef1e9a8856cf6 was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de3adf1bc0032ea5d195dfb80ebef1e9a8856cf6

commit de3adf1bc0032ea5d195dfb80ebef1e9a8856cf6
Author: erikchen <erikchen@chromium.org>
Date: Fri Sep 07 14:41:55 2018

[Merge to 3538] Add another shortcut for inspect element keyboard shortcut.

The inspect element keyboard shortcut when it was added 8 years ago was
intended to be command + shift + c. Due to a bug in the implementation, it
triggered off of both <cmd + shift +c> and <cmd + option + c>.

See https://codereview.chromium.org/3011002.

Recent refactors fixed the logic so that it correctly triggered off of only <cmd
+ shift + c>. Since some users have gotten used to <cmd + option + c>, this CL
manually adds that also as a hidden shortcut for devtools.

Bug:  880867 
Change-Id: Idb70ee26afa485874674171642b8d380b50528ad
Reviewed-on: https://chromium-review.googlesource.com/1211504
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589328}(cherry picked from commit 7ee15a5089815f2c83ce7795ef5676b3ef071b85)
Reviewed-on: https://chromium-review.googlesource.com/1213505
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#137}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/de3adf1bc0032ea5d195dfb80ebef1e9a8856cf6/chrome/browser/global_keyboard_shortcuts_mac.mm

Thanks all for the swift response and action! Such a small change but definitely caused hiccups in workflow. 

M69 branch 3497 merge was approved at #21.

Seems like this got merged to M70 branch 3538 without approval per comment #23. 

Approving merge for M70. Branch:3538

Able to reproduce the issue on Mac 10.13.3 using chrome reported version #69.0.3497.81

Verified the fix on Mac 10.13.3 using chrome version #69.0.3497.91 as per the comment #0.
Attaching screen cast for reference.
Observed that devtools window opened with the elements panel as the active panel using ⌘+⌥ + c (command + option + c).
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!

Deleted: 880867@M69.mp4 774 KB

	880867@M69.mp4 774 KB View Download

Verified the fix on mac 10.13.3 using chrome version #69.0.3497.92 and fix is working as expected. Hence adding TE-Verified labels.

Thanks...!!

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Able to reproduce the issue on Mac 10.13.3 using chrome reported version #69.0.3497.81

Verified the fix on Mac 10.13.3 using chrome version #70.0.3538.16 as per the comment #0.
Attaching screen cast for reference.
Observed that devtools window opened with the elements panel as the active panel using ⌘+⌥ + c (command + option + c).
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!

Deleted: 880867@M70.mp4 628 KB

	880867@M70.mp4 628 KB View Download