New issue
Advanced search Search tips

Issue 880861 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 840703



Sign in to add a comment

Get account from Personal data manager instead of IdentityManager

Project Member Reported by se...@chromium.org, Sep 5

Issue description

Get account from Personal data manager instead of IdentityManager

The CL has already landed here:
https://chromium-review.googlesource.com/c/chromium/src/+/1184030
 
Labels: Merge-Request-70
This has been picked-up by Canary, and we should now be able to merge it to M70
Labels: -Merge-Request-70 Merge-Approved-70
approved - branch:3538
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/590bda625954a92561db163f71d4e58679ff9e6c

commit 590bda625954a92561db163f71d4e58679ff9e6c
Author: sebsg <sebsg@chromium.org>
Date: Wed Sep 05 21:35:27 2018

Merge-70 [AF] Get account from PDM instead of IdentityManager

Actually Two changes bundled here

1) Get account from Personal data manager instead of IdentityManager
2) (Small helper method) Personal datamanager changes to denote fullsync user or not that can be propagated to rest of the Autofill module.
Goal is to send it to payment RPCs.

TBR=sebsg@chromium.org

(cherry picked from commit 7ba5ea846937be95a60328d783cec459296f32d9)

Bug:  880861 , 840703
Change-Id: I61422018c9fe6755f7315ccc692ab6245ed754da
Reviewed-on: https://chromium-review.googlesource.com/1184030
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588608}
Reviewed-on: https://chromium-review.googlesource.com/1208137
Cr-Commit-Position: refs/branch-heads/3538@{#67}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/DEPS
[add] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/account_info_getter.h
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/local_card_migration_manager_unittest.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/payments/payments_client.h
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/payments/payments_util.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/payments/test_payments_client.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/payments/test_payments_client.h
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/test_autofill_manager.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/test_personal_data_manager.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/browser/test_personal_data_manager.h
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/payments/core/autofill_payment_instrument_unittest.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/components/payments/core/test_payment_request_delegate.cc
[modify] https://crrev.com/590bda625954a92561db163f71d4e58679ff9e6c/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)
Labels: butter-hotlist

Sign in to add a comment