Update logic to mark Chrome versions -devel in UMA if the build is not Google Chrome branded |
||
Issue descriptionUpdate logic to mark Chrome versions -devel if the build is not Google Chrome branded. Right now, we only look at whether it's official. We should check both official and branded.
,
Sep 5
It would be nicer, but given we need to still support old clients that send -devel, it would actually make server-side logic more complex. So not sure it's worth it for now given it's also a bit more work.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/430271207ebd5af48a432e9de7154383bf14a3d2 commit 430271207ebd5af48a432e9de7154383bf14a3d2 Author: Alexei Svitkine <asvitkine@chromium.org> Date: Wed Sep 05 19:12:48 2018 Add -devel suffix in UMA versions for non-Chrome-branded builds. Previously, it would do this only for non-official builds. Now, we check both. Bug: 880853 Change-Id: I0f37a32ede20cdcb7379a748341203eab7028cf1 Reviewed-on: https://chromium-review.googlesource.com/1207211 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#588961} [modify] https://crrev.com/430271207ebd5af48a432e9de7154383bf14a3d2/components/metrics/version_utils.cc
,
Sep 5
|
||
►
Sign in to add a comment |
||
Comment 1 by holte@chromium.org
, Sep 5