New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Two empty bookmarks folders

Reported by gbdematos@gmail.com, Sep 5

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Steps to reproduce the problem:
1. Create two folders in the bookmarks bar
2. Click one of them, see the "Empty" placeholder
3. Move the cursor to the folder on the side (it may or not be empty)
4. Move the cursor back to the previous folder, you'll see 2 placeholders
5. Keep moving the cursor between the folders and the placeholders count keeps growing.

What is the expected behavior?
Only one "Empty" placeholder should be shown.

What went wrong?
I don't know.

Did this work before? N/A 

Chrome version: 69.0.3497.81  Channel: beta
OS Version: 10.0
Flash Version:
 
Components: -UI UI>Browser>Bookmarks
Can you please attach a screencast of the bug? Thanks in advance.
Labels: Needs-Triage-M69
Cc: krajshree@chromium.org
Labels: Triaged-ET Needs-Feedback
As per comment #1, adding Needs-Feedback label. Please provide a screen cast from your end for better understanding of the issue which will help us in triaging the issue further.

Thanks...!!
Here's a screencast gif of the bug.
google-chrome-bug.gif
345 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 6

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug -Pri-2 Needs-Bisect OS-Chrome OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Wow, I can reproduce it with Canary on OSX. Looks amazing :)
 Issue 881547  has been merged into this issue.
Cc: vamshi.kommuri@chromium.org hs1217....@samsung.com
Labels: -Needs-Bisect ReleaseBlock-Stable M-69 Target-70 Target-71 RegressedIn-69 FoundIn-71 FoundIn-70 hasbisect Target-69 FoundIn-69
Able to reproduce the issue on reported chrome version 69.0.3497.81 and on the latest canary 71.0.3544.0 using Windows 10, Mac 10.13.1 and Ubuntu 14.04

Bisect Information:
--------------------
Good Build: 69.0.3486.0
Bad build:  69.0.3487.0

Note: Providing with the manual changelog from https://omahaproxy.appspot.com/ as we are getting unrelated CLs when we run the tool bisect, it didn't help even after trying by changing revision numbers.

Manual Changelog:
-----------------
https://chromium.googlesource.com/chromium/src/+log/69.0.3486.0..69.0.3487.0?pretty=fuller&n=10000

Requesting someone from "UI>Browser>Bookmarks" team to help us in assigning it to the right owner and CC'ing Hwanseung Lee, from https://chromium-review.googlesource.com/c/chromium/src/+/1124719 which is related to Bookmarks.

Thanks!
 Issue 881281  has been merged into this issue.
Cc: pbomm...@chromium.org a...@chromium.org gov...@chromium.org ellyjo...@chromium.org
Components: Internals>Views>Desktop
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
You are probably looking for a change made after 573382 (known good), but no later than 573383 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/1b1b7d30b843e60d2d51105f7e3c5c5a0d866839..573df3ecda25f48e93c1985ebfe7954b598c2724
Labels: -Pri-1 -ReleaseBlock-Stable -M-69 M-70 Pri-2
Amusing but not RBS or M69.
Issue 882006 has been merged into this issue.
 Issue 882855  has been merged into this issue.
Labels: -Target-69 -Target-70 -M-70 M-71
Owner: ellyjo...@chromium.org
Taking this on since spqchan@ is changing teams.
Labels: Hotlist-ConOps
Cc: susan.boorgula@chromium.org
 Issue 885295  has been merged into this issue.
 Issue 886989  has been merged into this issue.
Cc: phanindra.mandapaka@chromium.org
 Issue 889836  has been merged into this issue.
 Issue 889773  has been merged into this issue.
 Issue 890612  has been merged into this issue.
Can I take a look into this issue 
if this issue's difficulty is the same as the good first bug?
If so, a good start point might be helpful to me Thanks!
#21: You're welcome to look into it if you'd like.

I would probably start by tracking down the code responsible for creating or displaying the (empty) menu entries. Since UI strings like that are internationalized, you'll need to look in a .grd or .grdp file for the entry: <https://cs.chromium.org/search/?q=%5C(empty%5C)+file:.grd&sq=package:chromium&type=cs>

That reveals IDS_APP_MENU_EMPTY_SUBMENU which seems like a likely candidate. Code searching for uses of it: <https://cs.chromium.org/search/?q=IDS_APP_MENU_EMPTY_SUBMENU&sq=package:chromium&type=cs>

Points toward this file: <https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_item_view.cc?type=cs&q=IDS_APP_MENU_EMPTY_SUBMENU&sq=package:chromium&g=0&l=52>

So hopefully that gives you a place to start debugging. Please let me know if you do pick this up and I'll defer my own work on it.
#22: Thanks, now I start digging this issue. :)
I upload the CL to fix this issue. :)

https://chromium-review.googlesource.com/c/chromium/src/+/1254601

Thanks!
Cc: ajha@chromium.org ligim...@chromium.org
Vamshi, could you please verify the fix once the CL lands in canary.
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e10253a1dd04c572145e283df67ddfdbe6394726

commit e10253a1dd04c572145e283df67ddfdbe6394726
Author: Dong-hee Na <donghee.na92@gmail.com>
Date: Sat Oct 06 07:21:11 2018

Bookmarks: Fix multiple empty bookmarks folders growing situation.

There is a bug with handling an empty bookmark folder.
This bug is reproduced when a bookmark bar has 2 folders
and at least one folder is an empty folder.

1. Click one of them, see the "Empty" placeholder
2. Move the cursor to the folder on the side
3. Move the cursor back to the previous folder,
   you'll see 2 placeholders
4. Keep moving the cursor between the folders
   and the placeholders count keeps growing.

To fix this bug,
I 've added the new member method 'HasEmptyMenuItemView()'
to check whether SubmenuView has at least one empty menu item.

So if submenu does not have visible children but also there is
no empty menu item then create an empty menu item.

This CL also maintain the functionality which was fixed
in crbug/852915.

Also, the unit test is also updated to cover this situation.

Bug:  880852 ,  852915 
Change-Id: I61d683f74f6283ba7337c6724b1e267ca91230fb
Reviewed-on: https://chromium-review.googlesource.com/c/1254601
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#597417}
[modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/menu_item_view.cc
[modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/menu_item_view_unittest.cc
[modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/submenu_view.cc
[modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/submenu_view.h

Labels: TE-Verified-M71 TE-Verified-71.0.3572.0
Re: C#25,
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #71.0.3572.0 as per the comment #0.
Attaching screen cast for reference.
Observed a single entry "empty" is seen on hovering.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!
880852 CL.mp4
545 KB View Download
If there is no other issue, Can I change this issue status into fixed?
Status: Fixed (was: Assigned)
Looks Fixed to me :) Thanks for your contribution!
 Issue 896622  has been merged into this issue.
 Issue 897813  has been merged into this issue.
 Issue 898331  has been merged into this issue.
 Issue 898960  has been merged into this issue.
 Issue 899763  has been merged into this issue.
Cc: viswa.karala@chromium.org
 Issue 899233  has been merged into this issue.
Issue 900029 has been merged into this issue.
Labels: -TE-Verified-M71 -TE-Verified-71.0.3572.0
Status: Verified (was: Fixed)
Checked on 72.0.3596.0
 Issue 901634  has been merged into this issue.
 Issue 902769  has been merged into this issue.
 Issue 900338  has been merged into this issue.
 Issue 906407  has been merged into this issue.
 Issue 906814  has been merged into this issue.
 Issue 907931  has been merged into this issue.
 Issue 908413  has been merged into this issue.

Sign in to add a comment