Two empty bookmarks folders
Reported by
gbdematos@gmail.com,
Sep 5
|
||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36 Steps to reproduce the problem: 1. Create two folders in the bookmarks bar 2. Click one of them, see the "Empty" placeholder 3. Move the cursor to the folder on the side (it may or not be empty) 4. Move the cursor back to the previous folder, you'll see 2 placeholders 5. Keep moving the cursor between the folders and the placeholders count keeps growing. What is the expected behavior? Only one "Empty" placeholder should be shown. What went wrong? I don't know. Did this work before? N/A Chrome version: 69.0.3497.81 Channel: beta OS Version: 10.0 Flash Version:
,
Sep 5
,
Sep 6
As per comment #1, adding Needs-Feedback label. Please provide a screen cast from your end for better understanding of the issue which will help us in triaging the issue further. Thanks...!!
,
Sep 6
Here's a screencast gif of the bug.
,
Sep 6
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6
Wow, I can reproduce it with Canary on OSX. Looks amazing :)
,
Sep 7
Issue 881547 has been merged into this issue.
,
Sep 7
Able to reproduce the issue on reported chrome version 69.0.3497.81 and on the latest canary 71.0.3544.0 using Windows 10, Mac 10.13.1 and Ubuntu 14.04 Bisect Information: -------------------- Good Build: 69.0.3486.0 Bad build: 69.0.3487.0 Note: Providing with the manual changelog from https://omahaproxy.appspot.com/ as we are getting unrelated CLs when we run the tool bisect, it didn't help even after trying by changing revision numbers. Manual Changelog: ----------------- https://chromium.googlesource.com/chromium/src/+log/69.0.3486.0..69.0.3487.0?pretty=fuller&n=10000 Requesting someone from "UI>Browser>Bookmarks" team to help us in assigning it to the right owner and CC'ing Hwanseung Lee, from https://chromium-review.googlesource.com/c/chromium/src/+/1124719 which is related to Bookmarks. Thanks!
,
Sep 7
Issue 881281 has been merged into this issue.
,
Sep 7
You are probably looking for a change made after 573382 (known good), but no later than 573383 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1b1b7d30b843e60d2d51105f7e3c5c5a0d866839..573df3ecda25f48e93c1985ebfe7954b598c2724
,
Sep 7
Amusing but not RBS or M69.
,
Sep 7
Issue 882006 has been merged into this issue.
,
Sep 11
Issue 882855 has been merged into this issue.
,
Sep 13
Taking this on since spqchan@ is changing teams.
,
Sep 14
,
Sep 19
,
Sep 21
Issue 886989 has been merged into this issue.
,
Sep 28
,
Sep 28
Issue 889773 has been merged into this issue.
,
Sep 30
Issue 890612 has been merged into this issue.
,
Sep 30
Can I take a look into this issue if this issue's difficulty is the same as the good first bug? If so, a good start point might be helpful to me Thanks!
,
Oct 1
#21: You're welcome to look into it if you'd like. I would probably start by tracking down the code responsible for creating or displaying the (empty) menu entries. Since UI strings like that are internationalized, you'll need to look in a .grd or .grdp file for the entry: <https://cs.chromium.org/search/?q=%5C(empty%5C)+file:.grd&sq=package:chromium&type=cs> That reveals IDS_APP_MENU_EMPTY_SUBMENU which seems like a likely candidate. Code searching for uses of it: <https://cs.chromium.org/search/?q=IDS_APP_MENU_EMPTY_SUBMENU&sq=package:chromium&type=cs> Points toward this file: <https://cs.chromium.org/chromium/src/ui/views/controls/menu/menu_item_view.cc?type=cs&q=IDS_APP_MENU_EMPTY_SUBMENU&sq=package:chromium&g=0&l=52> So hopefully that gives you a place to start debugging. Please let me know if you do pick this up and I'll defer my own work on it.
,
Oct 1
#22: Thanks, now I start digging this issue. :)
,
Oct 2
I upload the CL to fix this issue. :) https://chromium-review.googlesource.com/c/chromium/src/+/1254601 Thanks!
,
Oct 2
Vamshi, could you please verify the fix once the CL lands in canary.
,
Oct 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e10253a1dd04c572145e283df67ddfdbe6394726 commit e10253a1dd04c572145e283df67ddfdbe6394726 Author: Dong-hee Na <donghee.na92@gmail.com> Date: Sat Oct 06 07:21:11 2018 Bookmarks: Fix multiple empty bookmarks folders growing situation. There is a bug with handling an empty bookmark folder. This bug is reproduced when a bookmark bar has 2 folders and at least one folder is an empty folder. 1. Click one of them, see the "Empty" placeholder 2. Move the cursor to the folder on the side 3. Move the cursor back to the previous folder, you'll see 2 placeholders 4. Keep moving the cursor between the folders and the placeholders count keeps growing. To fix this bug, I 've added the new member method 'HasEmptyMenuItemView()' to check whether SubmenuView has at least one empty menu item. So if submenu does not have visible children but also there is no empty menu item then create an empty menu item. This CL also maintain the functionality which was fixed in crbug/852915. Also, the unit test is also updated to cover this situation. Bug: 880852 , 852915 Change-Id: I61d683f74f6283ba7337c6724b1e267ca91230fb Reviewed-on: https://chromium-review.googlesource.com/c/1254601 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#597417} [modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/menu_item_view.cc [modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/menu_item_view_unittest.cc [modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/submenu_view.cc [modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/submenu_view.h
,
Oct 8
Re: C#25, Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #71.0.3572.0 as per the comment #0. Attaching screen cast for reference. Observed a single entry "empty" is seen on hovering. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!!
,
Oct 10
If there is no other issue, Can I change this issue status into fixed?
,
Oct 10
Looks Fixed to me :) Thanks for your contribution!
,
Oct 18
Issue 896622 has been merged into this issue.
,
Oct 23
Issue 897813 has been merged into this issue.
,
Oct 24
Issue 898331 has been merged into this issue.
,
Oct 26
Issue 898960 has been merged into this issue.
,
Oct 29
Issue 899763 has been merged into this issue.
,
Oct 30
,
Oct 31
Issue 900029 has been merged into this issue.
,
Oct 31
Checked on 72.0.3596.0
,
Nov 5
Issue 901634 has been merged into this issue.
,
Nov 7
Issue 902769 has been merged into this issue.
,
Nov 8
Issue 900338 has been merged into this issue.
,
Nov 19
Issue 906407 has been merged into this issue.
,
Nov 21
Issue 906814 has been merged into this issue.
,
Nov 23
Issue 907931 has been merged into this issue.
,
Nov 27
Issue 908413 has been merged into this issue. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by meh...@chromium.org
, Sep 5