New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880851 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ChromeOS debug logs lack OS and Chrome version information

Project Member Reported by teravest@chromium.org, Sep 5

Issue description

Partners will frequently share debug logs to provide context when filing a bug or diagnosing a problem. Feedback reports have this information, but it's not stored in any of the files that are packaged up with debug logs.

The easiest thing would be to just copy /etc/lsb-release into the debug logs output. Ideally this wouldn't duplicate information in feedback reports, but I don't know how difficult it is to handle that properly.

Example fields:
CHROME VERSION=70.0.3511.0 dev
CHROMEOS_RELEASE_DESCRIPTION=10956.0.0 (Official Build) dev-channel octopus-unibuild (yorp bip unprovisioned_phaser phaser phaser360 unprovisioned_fleex fleex grabbiter orbatrix unprovisioned_bobba bobba bobba360 sparky sparky360 unprovisioned_meep meep mimrock)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1c4b97b3a5743582f8ee096830b7cf0ef265f2d4

commit 1c4b97b3a5743582f8ee096830b7cf0ef265f2d4
Author: Kartik Hegde <khegde@chromium.org>
Date: Mon Sep 17 21:28:54 2018

debugd: Add LsbRelease contents

Partners will frequently share debug logs to provide context when filing
a bug or diagnosing a problem. Feedback reports have this information,
but it's not stored in any of the files that are packaged up with debug
logs.

This commit adds version information to debugd output so that it is
present in debug logs.

A subsequent change will be made in the chrome source. That change will
stop chrome from fetching the lsb release contents on its own, which is
ok to do so because debugd will be fetching the lsb contents.
Here is the link to the subsequent chrome change:
https://chromium-review.googlesource.com/c/chromium/src/+/1217348

BUG=chromium:880851
TEST=Manually checked chrome://system

Change-Id: I37e6317754df42266d36fcbfac7a43bb68c23ac0
Reviewed-on: https://chromium-review.googlesource.com/1217083
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Kartik Hegde <khegde@chromium.org>

[modify] https://crrev.com/1c4b97b3a5743582f8ee096830b7cf0ef265f2d4/debugd/src/log_tool.cc
[modify] https://crrev.com/1c4b97b3a5743582f8ee096830b7cf0ef265f2d4/libbrillo/brillo/osrelease_reader.cc
[modify] https://crrev.com/1c4b97b3a5743582f8ee096830b7cf0ef265f2d4/libbrillo/brillo/osrelease_reader.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcbbb2fda2c82e5b83bfb6a5a0177cfbb83f6b8b

commit dcbbb2fda2c82e5b83bfb6a5a0177cfbb83f6b8b
Author: Kartik Hegde <khegde@chromium.org>
Date: Wed Sep 26 20:13:23 2018

Remove fetching lsb contents from chrome

Partners will frequently share debug logs to provide context when filing
a bug or diagnosing a problem. Feedback reports have this information,
but it's not stored in any of the files that are packaged up with debug
logs.

This commit follows the CL below, which makes debugd responsible for
fetching the lsb release contents:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1217083

BUG=chromium:880851
TEST=Manually checked chrome://system to ensure that lsb release
contents are present even after removing them from the chrome source.
Also checked that chrome://system loads properly and with correct output
when both debugd and chrome are reporting the lsb release contents.

Change-Id: I4651c5168c26ac696d5799c44126e5dcd6b4ce19
Reviewed-on: https://chromium-review.googlesource.com/1217344
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594453}
[modify] https://crrev.com/dcbbb2fda2c82e5b83bfb6a5a0177cfbb83f6b8b/base/sys_info.h
[modify] https://crrev.com/dcbbb2fda2c82e5b83bfb6a5a0177cfbb83f6b8b/base/sys_info_chromeos.cc
[modify] https://crrev.com/dcbbb2fda2c82e5b83bfb6a5a0177cfbb83f6b8b/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/537a208c5d63216526c29a9a7eed090513a3497e/chrome/browser/chromeos/system_logs/lsb_release_log_source.cc
[delete] https://crrev.com/537a208c5d63216526c29a9a7eed090513a3497e/chrome/browser/chromeos/system_logs/lsb_release_log_source.h
[modify] https://crrev.com/dcbbb2fda2c82e5b83bfb6a5a0177cfbb83f6b8b/chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc
[modify] https://crrev.com/dcbbb2fda2c82e5b83bfb6a5a0177cfbb83f6b8b/chrome/browser/feedback/system_logs/chrome_system_logs_fetcher.cc

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment