New issue
Advanced search Search tips

Issue 880845 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

Add metrics to tab grid to track close all / undo and re-ordering.

Project Member Reported by marq@chromium.org, Sep 5

Issue description

Add metrics to the tab grid to track:

 - Use of the new Close All and Undo Close All controls.
 - Use of interactive tab grid reordering.

 
Components: UI>Browser>Mobile>TabSwitcher
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e1dcb4f423ddf2717e17082ad2d10cb44340eb

commit d5e1dcb4f423ddf2717e17082ad2d10cb44340eb
Author: Mark Cogan <marq@google.com>
Date: Fri Sep 07 09:09:36 2018

[iOS] Add more Tab Grid metrics.

This CL adds metrics to track:
  - Use of the new Close All and Undo Close All controls.
  - Use of interactive tab grid reordering.

Bug:  880845 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I822044ea7bd1065a987d50dd03842662fa618a41
Reviewed-on: https://chromium-review.googlesource.com/1206433
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589468}
[modify] https://crrev.com/d5e1dcb4f423ddf2717e17082ad2d10cb44340eb/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/d5e1dcb4f423ddf2717e17082ad2d10cb44340eb/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/d5e1dcb4f423ddf2717e17082ad2d10cb44340eb/tools/metrics/actions/actions.xml

Labels: Merge-Request-70
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 11

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 11

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ab19c96ab8e4d630d20ba383da376e507381f1c

commit 9ab19c96ab8e4d630d20ba383da376e507381f1c
Author: Mark Cogan <marq@google.com>
Date: Tue Sep 11 16:51:09 2018

[iOS] Add more Tab Grid metrics.

This CL adds metrics to track:
  - Use of the new Close All and Undo Close All controls.
  - Use of interactive tab grid reordering.

Bug:  880845 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I822044ea7bd1065a987d50dd03842662fa618a41
Reviewed-on: https://chromium-review.googlesource.com/1206433
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589468}(cherry picked from commit d5e1dcb4f423ddf2717e17082ad2d10cb44340eb)
Reviewed-on: https://chromium-review.googlesource.com/1219931
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#273}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/9ab19c96ab8e4d630d20ba383da376e507381f1c/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/9ab19c96ab8e4d630d20ba383da376e507381f1c/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/9ab19c96ab8e4d630d20ba383da376e507381f1c/tools/metrics/actions/actions.xml

Sign in to add a comment