prefs.autofill.enabled.value is deprecated and should not be used to control enabling/disabling the "Add Profile" functionality in the settings page. It is currently used here: https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html?l=52
To be tackled in pending change https://chromium-review.googlesource.com/c/chromium/src/+/1205536
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45e35ec4e91b327307ab8e0bb896ce08e5381d7a commit 45e35ec4e91b327307ab8e0bb896ce08e5381d7a Author: Jason Guo <jiahuiguo@chromium.org> Date: Wed Sep 05 22:04:50 2018 [Autofill] Fix pref name in settings. Details please refer to the bug threads. Bug: 880552 , 880833 Change-Id: I90705523da9c513a70990647915422b574b02753 Reviewed-on: https://chromium-review.googlesource.com/1205536 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#589019} [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/test/data/webui/settings/autofill_section_test.js [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/test/data/webui/settings/payments_section_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a3d5a73a76fd3a1c02df491461eb42b636f5bea commit 5a3d5a73a76fd3a1c02df491461eb42b636f5bea Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Sep 07 00:29:25 2018 [Autofill] Fix pref name in settings. Details please refer to the bug threads. TBR=jiahuiguo@chromium.org (cherry picked from commit 45e35ec4e91b327307ab8e0bb896ce08e5381d7a) Bug: 880552 , 880833 Change-Id: I90705523da9c513a70990647915422b574b02753 Reviewed-on: https://chromium-review.googlesource.com/1205536 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589019} Reviewed-on: https://chromium-review.googlesource.com/1211920 Cr-Commit-Position: refs/branch-heads/3538@{#120} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/test/data/webui/settings/autofill_section_test.js [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/test/data/webui/settings/payments_section_test.js
Comment 1 by ma...@chromium.org
, Sep 5Status: Started (was: Assigned)