https://chromium-review.googlesource.com/c/chromium/src/+/1124697 introduced unique name matching for Linux. With this bug we track hooking this service up to Blink's font matching.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc4685a45b0208320af1bf35d664d998c331042b commit fc4685a45b0208320af1bf35d664d998c331042b Author: Dominik Röttsches <drott@chromium.org> Date: Thu Sep 06 18:11:29 2018 Rename WebFallbackFont To OutOfProcessFont Preparation for adding a postscript and full font name unique matching function to WebSandboxSupport, in which a similar return type is needed, but the use case is not fallback. BUG= 880832 Change-Id: Ibb66f3fe0007c517d74f56ba10096141b702676e Reviewed-on: https://chromium-review.googlesource.com/1209842 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#589214} [modify] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/content/child/child_process_sandbox_support_impl_linux.cc [modify] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/content/child/child_process_sandbox_support_impl_linux.h [modify] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/content/ppapi_plugin/ppapi_blink_platform_impl.cc [modify] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/content/utility/utility_blink_platform_with_sandbox_support_impl.cc [modify] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/third_party/blink/public/BUILD.gn [rename] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/third_party/blink/public/platform/linux/out_of_process_font.h [modify] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/third_party/blink/public/platform/linux/web_sandbox_support.h [modify] https://crrev.com/fc4685a45b0208320af1bf35d664d998c331042b/third_party/blink/renderer/platform/fonts/linux/font_cache_linux.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09 commit 5bc5a4c50a98a1ae992f4295ac611e55c7f69d09 Author: Dominik Röttsches <drott@chromium.org> Date: Fri Sep 07 10:22:18 2018 Connect Linux Font Unique Name Lookup to Blink Provide a new subclass for font unique name lookup for Linux. Connect via WebSandboxSupport to FontLoader which provides the out of process fontconfig calls for us. Tested by content_browsertests with a DevTools based test checking used fonts. This test was previously active on Android and is enabled for Linux in this CL. Bug: 880832 Change-Id: I04d72fc1cfcfa55a01a9877ac8a3a45dbff38771 Reviewed-on: https://chromium-review.googlesource.com/1206337 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589482} [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/components/services/font/font_service_app.cc [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/content/child/child_process_sandbox_support_impl_linux.cc [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/content/child/child_process_sandbox_support_impl_linux.h [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/content/ppapi_plugin/ppapi_blink_platform_impl.cc [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/content/test/data/font_src_local_matching.html [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/content/utility/utility_blink_platform_with_sandbox_support_impl.cc [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/third_party/blink/public/platform/linux/web_sandbox_support.h [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/third_party/blink/renderer/platform/BUILD.gn [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/third_party/blink/renderer/platform/fonts/font_unique_name_lookup.cc [add] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/third_party/blink/renderer/platform/fonts/linux/font_unique_name_lookup_linux.cc [add] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/third_party/blink/renderer/platform/fonts/linux/font_unique_name_lookup_linux.h [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/third_party/blink/renderer/platform/fonts/skia/font_cache_skia.cc [modify] https://crrev.com/5bc5a4c50a98a1ae992f4295ac611e55c7f69d09/third_party/blink/renderer/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a14cdad84be70714b0696d32f1b3977d9ffde2d8 commit a14cdad84be70714b0696d32f1b3977d9ffde2d8 Author: Dominik Röttsches <drott@chromium.org> Date: Fri Sep 07 13:03:49 2018 Revert "Connect Linux Font Unique Name Lookup to Blink" This reverts commit 5bc5a4c50a98a1ae992f4295ac611e55c7f69d09. Reason for revert: Test passes only flakily on Linux Original change's description: > Connect Linux Font Unique Name Lookup to Blink > > Provide a new subclass for font unique name lookup for Linux. Connect > via WebSandboxSupport to FontLoader which provides the out of process > fontconfig calls for us. Tested by content_browsertests with a DevTools > based test checking used fonts. This test was previously active on > Android and is enabled for Linux in this CL. > > Bug: 880832 > Change-Id: I04d72fc1cfcfa55a01a9877ac8a3a45dbff38771 > Reviewed-on: https://chromium-review.googlesource.com/1206337 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589482} TBR=dgozman@chromium.org,eae@chromium.org,drott@chromium.org Change-Id: I811960048b2f37130e4be4cb9c693dc90040f30d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880832 Reviewed-on: https://chromium-review.googlesource.com/1213168 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#589500} [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/components/services/font/font_service_app.cc [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/content/child/child_process_sandbox_support_impl_linux.cc [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/content/child/child_process_sandbox_support_impl_linux.h [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/content/ppapi_plugin/ppapi_blink_platform_impl.cc [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/content/test/data/font_src_local_matching.html [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/content/utility/utility_blink_platform_with_sandbox_support_impl.cc [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/third_party/blink/public/platform/linux/web_sandbox_support.h [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/third_party/blink/renderer/platform/BUILD.gn [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/third_party/blink/renderer/platform/fonts/font_unique_name_lookup.cc [delete] https://crrev.com/31fba9dc3ef891a8a866f7472efc4c596abae32e/third_party/blink/renderer/platform/fonts/linux/font_unique_name_lookup_linux.cc [delete] https://crrev.com/31fba9dc3ef891a8a866f7472efc4c596abae32e/third_party/blink/renderer/platform/fonts/linux/font_unique_name_lookup_linux.h [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/third_party/blink/renderer/platform/fonts/skia/font_cache_skia.cc [modify] https://crrev.com/a14cdad84be70714b0696d32f1b3977d9ffde2d8/third_party/blink/renderer/platform/runtime_enabled_features.json5
Reopening, as the test needs to be made less flaky on Linux.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f973726bdfa204cd47b1ed97070d6b54e113c231 commit f973726bdfa204cd47b1ed97070d6b54e113c231 Author: Dominik Röttsches <drott@chromium.org> Date: Tue Sep 18 06:12:55 2018 Reland: Connect Linux Font Unique Name Lookup to Blink This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1206337 plus a fix for flakiness due to timing issues when the page under DevTools test had not completed layout. Added a forced synchronous layout in the test HTML page to avoid running into incompletely laid out nodes on the DevTools side of the text. Avoiding complete test case crashes by introducing better assertions that capture when we get empty results from DevTools. Remaining existing functionally has been previously reviewed. Provide a new subclass for font unique name lookup for Linux. Connect via WebSandboxSupport to FontLoader which provides the out of process fontconfig calls for us. Tested by content_browsertests with a DevTools based test checking used fonts. This test was previously active on Android and is enabled for Linux in this CL. Bug: 880832 Change-Id: Icc67e3286002c82f2c47ba7c788b82a80b282f54 Reviewed-on: https://chromium-review.googlesource.com/1228119 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#591955} [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/components/services/font/font_service_app.cc [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/content/child/child_process_sandbox_support_impl_linux.cc [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/content/child/child_process_sandbox_support_impl_linux.h [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/content/ppapi_plugin/ppapi_blink_platform_impl.cc [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/content/test/data/font_src_local_matching.html [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/content/utility/utility_blink_platform_with_sandbox_support_impl.cc [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/third_party/blink/public/platform/linux/web_sandbox_support.h [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/third_party/blink/renderer/platform/BUILD.gn [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/third_party/blink/renderer/platform/fonts/font_unique_name_lookup.cc [add] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/third_party/blink/renderer/platform/fonts/linux/font_unique_name_lookup_linux.cc [add] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/third_party/blink/renderer/platform/fonts/linux/font_unique_name_lookup_linux.h [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/third_party/blink/renderer/platform/fonts/skia/font_cache_skia.cc [modify] https://crrev.com/f973726bdfa204cd47b1ed97070d6b54e113c231/third_party/blink/renderer/platform/runtime_enabled_features.json5
Comment 1 by bugdroid1@chromium.org
, Sep 6